Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOpenCDM] Update with JSON-RPC interface #413

Merged
merged 14 commits into from
Feb 11, 2025

Conversation

VeithMetro
Copy link
Contributor

@VeithMetro VeithMetro commented Feb 4, 2025

After merging this PR, we have to also merge this PR with changes to the plugin

@VeithMetro VeithMetro changed the title [IOpenCDMi] Update with JSON-RPC interface [IOpenCDM] Update with JSON-RPC interface Feb 4, 2025
@VeithMetro
Copy link
Contributor Author

@pwielders what do you think about making keySystem an enum instead of a string? We talked about that with Sebastian, and have arguments for both.

On one hand, the CDMs list is finite and sending an enum would be more efficient, but on the other, OpenCDM don't need to know what DRM types exist

pwielders
pwielders previously approved these changes Feb 10, 2025
@pwielders
Copy link
Collaborator

@VeithMetro on you question. Agree and do have a preference for enums, however the interface specification was initially once drafted by the Frauenhofer Institute and a s long that there was no severe technical reason to deviate from what they specified, we did not modify it. So for me, as it is is fine but do agree that for a communication overhead the enum would be much better. So for sake of backwards compatibility with what Frauenhofer once specified, I vote for keeping it a string..

@MFransen69 MFransen69 merged commit f537f4a into master Feb 11, 2025
52 checks passed
@MFransen69 MFransen69 deleted the development/ocdm-interface branch February 11, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants