Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
로그인 UI 변경 #168
로그인 UI 변경 #168
Changes from 19 commits
fc3f05e
692be84
1758ea1
d19fbeb
dc2d6b2
8eec5aa
1a52150
36fae78
00269fc
0dbfa10
9cda4d9
81fc2db
29843a0
3e1b4ca
251738d
00c45c7
be95496
403f02a
251a475
beff118
2ef2507
1dec392
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아이디와 비밀번호로 로그인하는 폼을 컴포넌트로 분리하는게 낫다고 생각하여 분리하며 스타일 수정
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
로그인 완료시에 뒤로가기 하면 어떻게될까? 만약 뒤로가기가 불필요하다면 replace를 써도 될거같아
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
말해준대로 로그인 시 이전페이지로 가는 것이 더 올바른 작동방식이라고 생각이 들었엉 그렇지만 그냥 router.back()을 쓰자니 앞으로 가기가 남아져서 불편한 감을 느꼈고 replace를 사용하는 방법이 최적의 방법이라 생각했습니다.
그래서 로그인 페이지 이전에 경로를 받기 위해서 documet.referrer를 사용하려 했더니 서버사이드 렌더링에서는 그렇게 여유치 않았고 login 페이지로 이동하는 버튼을 클릭했을 때 sessionStorage에 previousURL값을 저장해두고 로그인 성공시 replace로 이동하는 것으로 로직을 수정했습니다.
만일 다이렉트로 로그인페이지로 왔다면 root로 돌아갈수 있게 하였습니다~
This file was deleted.