chore(apple): fix build issues discovered internally

Author: Saadnajmi

packages/default-storage/ios/RNCAsyncStorage.h

@@ -50,13 +50,13 @@
 
 // Grab data from the cache. ResponseBlock result array will have an error at position 0, and an
 // array of arrays at position 1.
-- (void)multiGet:(NSArray<NSString *> *)keys callback:(RCTResponseSenderBlock)callback;
+- (void)multiGet:(NSArray<NSString *> *_Nullable)keys callback:(RCTResponseSenderBlock _Nullable )callback;
 
 // Add multiple key value pairs to the cache.
-- (void)multiSet:(NSArray<NSArray<NSString *> *> *)kvPairs
-        callback:(RCTResponseSenderBlock)callback;
+- (void)multiSet:(NSArray<NSArray<NSString *> *> *_Nullable)kvPairs
+        callback:(RCTResponseSenderBlock _Nullable )callback;
 
 // Interface for natively fetching all the keys from the storage data.
-- (void)getAllKeys:(RCTResponseSenderBlock)callback;
+- (void)getAllKeys:(RCTResponseSenderBlock _Nullable )callback;
 
 @end

packages/default-storage/ios/RNCAsyncStorage.mm

@@ -302,7 +302,7 @@ static void RCTStorageDirectoryMigrate(NSString *oldDirectoryPath,
         // this folder and attempt folder copying again
         if (error != nil && error.code == 4 &&
             [newDirectoryPath isEqualToString:RCTGetStorageDirectory()]) {
-            NSError *error = nil;
+            error = nil;
             _createStorageDirectory(RCTCreateStorageDirectoryPath(@""), &error);
             if (error == nil) {
                 RCTStorageDirectoryMigrate(
@@ -559,7 +559,7 @@ - (NSDictionary *)_ensureSetup
     return nil;
 }
 
-- (NSDictionary *)_writeManifest:(NSMutableArray<NSDictionary *> **)errors
+- (NSDictionary *)_writeManifest:(NSMutableArray<NSDictionary *> *__autoreleasing *)errors
 {
     NSError *error;
     NSString *serialized = RCTJSONStringify(_manifest, &error);
@@ -587,7 +587,7 @@ - (NSDictionary *)_appendItemForKey:(NSString *)key
     return errorOut;
 }
 
-- (NSString *)_getValueForKey:(NSString *)key errorOut:(NSDictionary **)errorOut
+- (NSString *)_getValueForKey:(NSString *)key errorOut:(NSDictionary *__autoreleasing *)errorOut
 {
     NSString *value =
         _manifest[key];  // nil means missing, null means there may be a data file, else: NSString
@@ -699,14 +699,14 @@ - (BOOL)_passthroughDelegate
         }
     }
 
-    NSDictionary *errorOut = [self _ensureSetup];
-    if (errorOut) {
-        callback(@[@[errorOut], (id)kCFNull]);
+    NSDictionary *ensureSetupErrorOut = [self _ensureSetup];
+    if (ensureSetupErrorOut) {
+        callback(@[@[ensureSetupErrorOut], (id)kCFNull]);
         return;
     }
     [self _multiGet:keys
            callback:callback
-             getter:^(NSUInteger i, NSString *key, NSDictionary **errorOut) {
+             getter:^(__unused NSUInteger i, NSString *key, NSDictionary **errorOut) {
                return [self _getValueForKey:key errorOut:errorOut];
              }];
 }