Skip to content

chore: yet another follow up for changesets release #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

krizzu
Copy link
Member

@krizzu krizzu commented Jul 11, 2024

Summary

Couple of things:

  • I still have no idea why GH action is picking gh bot as git credentials (it works fine in a fork), so I'm using variables now for name and email for the bot
  • I've noticed during my tests that README would be mixed up by changeset, so I applied changes
  • Also I've noticed that one of our releases has not been pushed to npm, so added a warning for it in README
  • I've added api and sqlite-storage to ignore, to avoid changesets releasing it for now (not ready yet)

@krizzu krizzu requested a review from tido64 as a code owner July 11, 2024 22:23
Copy link

changeset-bot bot commented Jul 11, 2024

⚠️ No Changeset found

Latest commit: e735913

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@krizzu krizzu enabled auto-merge (squash) July 12, 2024 07:22
@krizzu krizzu merged commit 04587bc into main Jul 12, 2024
8 checks passed
@krizzu krizzu deleted the chore/release-followup branch July 12, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants