Skip to content

fix: do not persist credentials for release workflow #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

krizzu
Copy link
Member

@krizzu krizzu commented Jul 12, 2024

Summary

I hope this is the last follow up 😄 Turns out, even if we set git credentials during job run, the checkout step had set git credentials upfront, which took precedence over ours. Because of that, github-bot was used to create a branch, not @AsyncStorageBot .

@krizzu krizzu requested a review from tido64 as a code owner July 12, 2024 07:50
Copy link

changeset-bot bot commented Jul 12, 2024

⚠️ No Changeset found

Latest commit: f31fd36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@krizzu krizzu enabled auto-merge (squash) July 12, 2024 07:50
@krizzu krizzu merged commit f872676 into main Jul 12, 2024
8 checks passed
@krizzu krizzu deleted the chore/final-release-followup branch July 12, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants