Skip to content

Fixes the output example code multiMerge #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

mensonones
Copy link
Contributor

Fixes the output example code in the multiMerge API documentation.

Summary

This PR fixes the incorrect code output example for multiMerge.
Link Issue: #1137

Test Plan

Run sample code

Fixes the output example code in the multiMerge API documentation. react-native-async-storage#1137
Copy link

changeset-bot bot commented Aug 21, 2024

⚠️ No Changeset found

Latest commit: dbbcb06

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tido64 tido64 linked an issue Aug 21, 2024 that may be closed by this pull request
5 tasks
@krizzu
Copy link
Member

krizzu commented Aug 22, 2024

Looks good, just that this code won't run, as parsedCurrentlyMerged used in console.log is not reachable, due it being initialized in try block

@mensonones
Copy link
Contributor Author

Looks good, just that this code won't run, as parsedCurrentlyMerged used in console.log is not reachable, due it being initialized in try block

That's true! I didn't pay attention to that.
Thank you for the feedback!

fixed!

@krizzu krizzu merged commit 471a1b8 into react-native-async-storage:main Sep 10, 2024
@krizzu
Copy link
Member

krizzu commented Sep 10, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An example output in API Docs seems misleading
2 participants