From a681f42600abd2a2d1a71ee274fce88199a00944 Mon Sep 17 00:00:00 2001 From: Tommy Nguyen <4123478+tido64@users.noreply.github.com> Date: Mon, 24 Feb 2025 11:54:47 +0100 Subject: [PATCH 1/2] fix(android): remove unnecessary `getViewManagers` overrides --- .changeset/many-pianos-guess.md | 5 +++++ .../asyncstorage/AsyncStoragePackage.java | 7 +------ .../asyncstorage/AsyncStoragePackage.kt | 4 +--- 3 files changed, 7 insertions(+), 9 deletions(-) create mode 100644 .changeset/many-pianos-guess.md diff --git a/.changeset/many-pianos-guess.md b/.changeset/many-pianos-guess.md new file mode 100644 index 00000000..282994ec --- /dev/null +++ b/.changeset/many-pianos-guess.md @@ -0,0 +1,5 @@ +--- +"@react-native-async-storage/async-storage": patch +--- + +Remove unnecessary `getViewManagers` overrides diff --git a/packages/default-storage/android/src/javaPackage/java/com/reactnativecommunity/asyncstorage/AsyncStoragePackage.java b/packages/default-storage/android/src/javaPackage/java/com/reactnativecommunity/asyncstorage/AsyncStoragePackage.java index 0b9f2198..5b38a4df 100644 --- a/packages/default-storage/android/src/javaPackage/java/com/reactnativecommunity/asyncstorage/AsyncStoragePackage.java +++ b/packages/default-storage/android/src/javaPackage/java/com/reactnativecommunity/asyncstorage/AsyncStoragePackage.java @@ -31,11 +31,6 @@ ) public class AsyncStoragePackage extends TurboReactPackage { - @Override - protected List getViewManagers(ReactApplicationContext reactContext) { - return null; - } - @Override public NativeModule getModule(String name, @Nonnull ReactApplicationContext reactContext) { switch (name) { @@ -95,4 +90,4 @@ public Map getReactModuleInfos() { public List createViewManagers(ReactApplicationContext reactContext) { return Collections.emptyList(); } -} \ No newline at end of file +} diff --git a/packages/default-storage/android/src/kotlinPackage/java/com/reactnativecommunity/asyncstorage/AsyncStoragePackage.kt b/packages/default-storage/android/src/kotlinPackage/java/com/reactnativecommunity/asyncstorage/AsyncStoragePackage.kt index 0ddacf1b..5fd7989b 100644 --- a/packages/default-storage/android/src/kotlinPackage/java/com/reactnativecommunity/asyncstorage/AsyncStoragePackage.kt +++ b/packages/default-storage/android/src/kotlinPackage/java/com/reactnativecommunity/asyncstorage/AsyncStoragePackage.kt @@ -50,6 +50,4 @@ class AsyncStoragePackage : TurboReactPackage() { throw RuntimeException("No ReactModuleInfoProvider for AsyncStoragePackage$\$ReactModuleInfoProvider", e) } } - - override fun getViewManagers(reactContext: ReactApplicationContext?): MutableList? = null -} \ No newline at end of file +} From aa64f5d65ff9c0a21e771c845626dc3ffbf8c5f7 Mon Sep 17 00:00:00 2001 From: Tommy Nguyen <4123478+tido64@users.noreply.github.com> Date: Mon, 24 Feb 2025 12:39:12 +0100 Subject: [PATCH 2/2] disable Jetifier --- packages/default-storage/example/android/gradle.properties | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/default-storage/example/android/gradle.properties b/packages/default-storage/example/android/gradle.properties index 8f2be824..3c47b92a 100644 --- a/packages/default-storage/example/android/gradle.properties +++ b/packages/default-storage/example/android/gradle.properties @@ -25,9 +25,7 @@ org.gradle.jvmargs=-Xmx2g -XX:MaxMetaspaceSize=512m -XX:+HeapDumpOnOutOfMemoryEr # https://developer.android.com/topic/libraries/support-library/androidx-rn android.useAndroidX=true # Automatically convert third-party libraries to use AndroidX -android.enableJetifier=true -# Jetifier randomly fails on these libraries -android.jetifier.ignorelist=hermes-android +android.enableJetifier=false # Use this property to specify which architecture you want to build. # You can also override it from the CLI using