Revert "Remove old media/static files" #12210
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d179a3d. It seems we are referencing to a bunch of these files from a lot of places and we cannot delete them. We think we didn't notice the issue because these files are still in the S3 bucket, but if we move to another bucket or provider they will be missing and start failing.
humitos
added
PR: hotfix
|
Well, I'm not hotfixing this for now. We are not 100% sure we need it. |
|
Superseded by #12201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d179a3d.
It seems we are referencing to a bunch of these files from a lot of places and we cannot delete them.
We think we didn't notice the issue because these files are still in the S3 bucket, but if we move to another bucket or provider they will be missing and start failing.