Return 404 when user is not found

Author: santiagolizardo

composer.lock

@@ -13,8 +13,8 @@
 class UploadAttachmentController extends Controller
 {
     public function __construct(protected readonly AttachmentRepository $attachmentRepository,
-                                protected readonly AttachmentFilePath $attachmentFilePathService,
-                                protected readonly RedisServer $redisServer)
+                                protected readonly AttachmentFilePath   $attachmentFilePathService,
+                                protected readonly RedisServer          $redisServer)
     {
     }
 
@@ -31,7 +31,7 @@ public function __invoke(ServerRequestInterface $request, array $args): array
         $index = 0;
         foreach ($files as $file) {
             /** @var UploadedFileInterface $file */
-            $this->logger->debug('file uploaded', ['filename' => $file->getClientFilename(), 'type' => $file->getClientMediaType(), 'size' => $file->getSize()]);
+            $this->logger()->debug('file uploaded', ['filename' => $file->getClientFilename(), 'type' => $file->getClientMediaType(), 'size' => $file->getSize()]);
             $attachment = $this->uploadAttachment($file, $parentType, $parentId, $userId);
 
             if ('command' === $parentType) {
@@ -43,7 +43,7 @@ public function __invoke(ServerRequestInterface $request, array $args): array
                     ])
                 );
                 if (false === $queueLen) {
-                    $this->logger->error('Item could not be pushed to the queue', ['queue' => 'tasks-results:queue']);
+                    $this->logger()->error('Item could not be pushed to the queue', ['queue' => 'tasks-results:queue']);
                 }
             }
 

src/Controllers/Attachments/UploadAttachmentController.php

@@ -2,6 +2,7 @@
 
 namespace Reconmap\Controllers\Users;
 
+use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
 use Reconmap\Controllers\Controller;
 use Reconmap\Repositories\UserRepository;
@@ -12,13 +13,16 @@ public function __construct(private readonly UserRepository $userRepository)
     {
     }
 
-    public function __invoke(ServerRequestInterface $request, array $args): array
+    public function __invoke(ServerRequestInterface $request, array $args): array|ResponseInterface
     {
         $userId = (int)$args['userId'];
 
         $user = $this->userRepository->findById($userId);
 
-
+        if (null === $user) {
+            return $this->createNotFoundResponse();
+        }
+        
         if (is_string($user['preferences']) && json_validate($user['preferences'])) {
             $user['preferences'] = json_decode($user['preferences'], true);
         } else {

src/Controllers/Users/GetUserController.php

@@ -2,6 +2,8 @@
 
 namespace Reconmap\Controllers\Attachments;
 
+use Monolog\Logger;
+use Psr\Container\ContainerInterface;
 use Psr\Http\Message\ServerRequestInterface;
 use Psr\Http\Message\UploadedFileInterface;
 use Reconmap\ControllerTestCase;
@@ -67,7 +69,13 @@ public function testHappyPath()
 
         $args = ['attachmentId' => $fakeAttachmentId];
 
+        $mockContainer = $this->createMock(ContainerInterface::class);
+        $mockContainer->expects($this->once())
+            ->method('get')
+            ->willReturn($this->createStub(Logger::class));
+
         $controller = $this->injectController(new UploadAttachmentController($mockAttachmentRepository, $mockAttachmentFilePath, $mockRedisServer));
+        $controller->setContainer($mockContainer);
         $response = $controller($mockRequest, $args);
 
         $this->assertTrue($response['success']);