Hikari rewrite #25
Merged
Hikari rewrite #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Bot works as intended on review deployment 👍 |
Co-authored-by: XOREAX <57073484+koyakonsta@users.noreply.github.com>
novanai
force-pushed
the
hikari-rewrite
branch
from
393e644 to
dd53346
Compare
|
Possible minor improvements are tracked in #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a preview of what a rewrite to hikari could look like.
It uses hikari, the command handler hikari-arc and I would recommend hikari-miru for anything that utilises components.
I extracted the
main.pyfile intobot.py(which sets up the bot and command client) and__main__.py(which just runs the bot). The bot is now run using the commandpython3 -m src, but I have not updated the Dockerfile to reflect this.