Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor config #61

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Refactor config #61

merged 2 commits into from
Jan 14, 2025

Conversation

novanai
Copy link
Contributor

@novanai novanai commented Jan 14, 2025

Move assignable role IDs into config and add utility get_required_var function.

@novanai novanai linked an issue Jan 14, 2025 that may be closed by this pull request
Refactor role ids into config #29
Closed
wizzdom
wizzdom previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@wizzdom wizzdom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

LGTM

@novanai novanai requested a review from wizzdom January 14, 2025 14:12
@novanai novanai merged commit 661c210 into main Jan 14, 2025
4 checks passed
@novanai novanai deleted the refactor-config branch January 14, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wizzdom wizzdom wizzdom approved these changes

@aydenjahola aydenjahola Awaiting requested review from aydenjahola

@HypnoAnt HypnoAnt Awaiting requested review from HypnoAnt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor role ids into config
2 participants
@novanai @wizzdom