Ci fix (#1112)

* ci fix

* ci fix

* update linting

* update ci

Author: sean-m-sullivan

.github/files/calculate_change.sh

@@ -12,4 +12,4 @@ elif [ $MINOR -eq 0 ]; then
 else
   echo "level=patch" >> "$GITHUB_OUTPUT"
   echo "Determined change level: patch"
-fi
+fi

.github/workflows/pre-commit.yml

@@ -15,6 +15,7 @@ on:
     - 'v[0-9]+.[0-9]+.[0-9]+[abrc]+[0-9]+'  # alpha, beta, release candidate (rc)
     - 'v[0-9]+.[0-9]+.[0-9]+.dev[0-9]+'  # development versions
   pull_request:
+  pull_request_target:
   schedule:
     - cron: "0 6 * * *"
 

README.md

@@ -80,18 +80,21 @@ If you were using a version of infra.controller_configuration, please refer to o
 
 **Install This Collection:**
 Ensure this collection (`infra.aap_configuration`) is installed:
+
 ```bash
 ansible-galaxy collection install infra.aap_configuration
 ```
 
 **Run Playbooks from This Collection:**
 To execute a playbook packaged within this collection (e.g., `configure_aap.yml`):
+
 ```console
 ansible-playbook infra.aap_configuration.configure_aap.yml
 ```
 
 **Troubleshooting "couldn't resolve module/action":**
 This error usually means the required Ansible collection (e.g., `infra.aap_configuration` or a dependency like ansible.controller) is:
+
 * Not installed.
 * Incorrectly named in the playbook.
 * Not found in Ansible's configured collection paths.
@@ -103,20 +106,20 @@ Define following vars here, or in `aap_configs/controller_auth.yml`
 
 You can also specify authentication by a combination of either:
 
-- `aap_hostname`, `aap_username`, `aap_password`
-- `aap_hostname`, `aap_token`
+* `aap_hostname`, `aap_username`, `aap_password`
+* `aap_hostname`, `aap_token`
 
 The OAuth2 token is the preferred method. You can obtain the token through the preferred `controller_token` module, or through the
 AWX CLI [login](https://docs.ansible.com/automation-controller/latest/html/controllerapi/authentication.html)
 command.
 
 These can be specified via (from highest to lowest precedence):
 
-- direct role variables as mentioned above
-- environment variables (most useful when running against localhost)
-- a config file path specified by the `controller_config_file` parameter
-- a config file at `~/.controller_cli.cfg`
-- a config file at `/etc/controller/controller_cli.cfg`
+* direct role variables as mentioned above
+* environment variables (most useful when running against localhost)
+* a config file path specified by the `controller_config_file` parameter
+* a config file at `~/.controller_cli.cfg`
+* a config file at `/etc/controller/controller_cli.cfg`
 
 Config file syntax looks like this:
 
@@ -161,7 +164,7 @@ A [Template to use in order to start using the collections can be found here](ht
 
 ### See Also
 
-- [Ansible Using collections](https://docs.ansible.com/ansible/latest/user_guide/collections_using.html) for more details.
+[Ansible Using collections](https://docs.ansible.com/ansible/latest/user_guide/collections_using.html) for more details.
 
 ## Release and Upgrade Notes
 

roles/controller_workflow_job_templates/tasks/add_workflows_schema.yml

@@ -70,7 +70,7 @@
 
 # Create links between workflow node
 - name: add_workflows_schema | Create links between Workflow Nodes
-  workflow_job_template_node:
+  ansible.controller.workflow_job_template_node:
     identifier: "{{ __workflow_loop_node_item.identifier | mandatory }}"
     workflow: "{{ __workflow_loop_item.name | mandatory }}"
     always_nodes: "{{ __workflow_loop_node_item.always_nodes | default(__workflow_loop_node_item.related.always_nodes | default([], true) | selectattr('identifier',

roles/gateway_authenticators/README.md

@@ -122,6 +122,7 @@ gateway_authenticators:
 ### Run Playbook
 
 File name: [configure_aap.yml](https://github.com/redhat-cop/infra.aap_configuration/blob/devel/playbooks/configure_aap.yml) can be found in the top level playbooks directory.
+
 ```shell
 ansible-playbook infra.aap_configuration.configure_aap.yml
 ```

roles/gateway_organizations/README.md

@@ -146,6 +146,7 @@ aap_organizations:
 ### Run Playbook
 
 File name: [configure_aap.yml](https://github.com/redhat-cop/infra.aap_configuration/blob/devel/playbooks/configure_aap.yml) can be found in the top level playbooks directory.
+
 ```shell
 ansible-playbook infra.aap_configuration.configure_aap.yml
 ```

roles/gateway_role_user_assignments/README.md

@@ -100,6 +100,7 @@ gateway_role_user_assignments:
 ### Run Playbook
 
 File name: [configure_aap.yml](https://github.com/redhat-cop/infra.aap_configuration/blob/devel/playbooks/configure_aap.yml) can be found in the top level playbooks directory.
+
 ```shell
 ansible-playbook infra.aap_configuration.configure_aap.yml
 ```

tests/configure_controller.yml

@@ -9,7 +9,6 @@
   # aap_hostname: controller.example.com
   # aap_username: admin
   # aap_password: changeme
-    - infra.aap_configuration
 
   pre_tasks:
     - name: Determine collection (block)
@@ -175,7 +174,7 @@
         var: launched_controller_workflows
 
     - name: Wait for workflow to finish
-      job_wait:
+      ansible.controller.job_wait:
         job_id: "{{ launched_controller_workflows.results[0].id }}"
         job_type: workflow_jobs
         timeout: 180

tests/configure_controller_export_model.yml

@@ -5,7 +5,6 @@
   vars:
     workflow_job_templates_secure_logging: false
     aap_validate_certs: false
-    - infra.aap_configuration
   # Define following vars here, or in configs/controller_auth.yml
   # aap_hostname: controller.example.com
   # aap_username: admin

tests/configure_platform.yml

@@ -152,7 +152,7 @@
         var: launched_controller_workflows
 
     - name: Wait for workflow to finish
-      job_wait:
+      ansible.controller.job_wait:
         job_id: "{{ launched_controller_workflows.results[0].id }}"
         job_type: workflow_jobs
         timeout: 180