Prevent an empty automatic release #1115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is still possible to perform a release that has no changelogs (we may need to do this in some cercumstances), this is possible when we perform a manual release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I realised that at present if no changes had been made we would still create a new patch release. This shouldn't be the case. I've made it so that it is still possible to perform a release that has no changelogs (we may need to do this in some circumstances), this is possible when we perform a manual release.
How should this be tested?
See it stopping the release here when no changes: https://github.com/Tompage1994/controller_configuration/actions/runs/15344682751
and continuing here when there are: https://github.com/Tompage1994/controller_configuration/actions/runs/15344892665 (I cancelled it doing the actual deployment to galaxy/AH, but it still proves it out)
Is there a relevant Issue open for this?
resolves #1114
Other Relevant info, PRs, etc
Related to #1100