Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert setting storage class fields to null by default [RHIDP-5953] #97

Merged

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Feb 11, 2025

Description of the change

When the DB PVC is initially created, it gets assigned the default storage class.

And it becomes impossible to upgrade the Helm Release later on because it looks like the (immutable) PVC is being patched after creation

Existing or Associated Issue(s)

Relates to https://issues.redhat.com/browse/RHIDP-5953

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

rm3l added 2 commits February 11, 2025 18:11
When the PVC is initially created, it gets assigned the default storage class

And it becomes impossible to upgrade the Helm Release later on because it looks like the (immutable) PVC is being patched after creation
@openshift-ci openshift-ci bot requested review from coreydaley and kadel February 11, 2025 17:13
@rm3l rm3l changed the title fix: Revert setting storage class fields to null by default fix(main): Revert setting storage class fields to null by default Feb 11, 2025
@rm3l rm3l changed the title fix(main): Revert setting storage class fields to null by default fix(main): Revert setting storage class fields to null by default [RHIDP-5953] Feb 11, 2025
@rm3l
Copy link
Member Author

rm3l commented Feb 11, 2025

/cherry-pick release-1.5

@openshift-cherrypick-robot

@rm3l: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rm3l rm3l changed the title fix(main): Revert setting storage class fields to null by default [RHIDP-5953] fix: Revert setting storage class fields to null by default [RHIDP-5953] Feb 11, 2025
…s previous version

When using the '–upgrade' flag, regression testing will only be performed if the major version of the Chart is not changed (Semver).

Otherwise, normal testing will still happen.
@rm3l rm3l merged commit f9973ae into redhat-developer:main Feb 12, 2025
5 of 6 checks passed
@rm3l rm3l deleted the RHIDP-5953--revert-null-storage-class--main branch February 12, 2025 13:05
@openshift-cherrypick-robot

@rm3l: new pull request created: #100

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants