From 08bcedaa09f2d1db2540db5d8de40e41cb763bb1 Mon Sep 17 00:00:00 2001 From: Armel Soro Date: Tue, 11 Feb 2025 18:11:13 +0100 Subject: [PATCH 1/4] Revert setting storageClass fields to null by default When the PVC is initially created, it gets assigned the default storage class And it becomes impossible to upgrade the Helm Release later on because it looks like the (immutable) PVC is being patched after creation --- charts/backstage/values.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/charts/backstage/values.yaml b/charts/backstage/values.yaml index 8ef7ba81..a7c2ca3d 100644 --- a/charts/backstage/values.yaml +++ b/charts/backstage/values.yaml @@ -268,7 +268,6 @@ upstream: enabled: true size: 1Gi mountPath: /var/lib/pgsql/data - storageClass: null extraEnvVars: - name: POSTGRESQL_ADMIN_PASSWORD valueFrom: From c4dc682e379a6e3cc7df819e95b6f856d7a99ab6 Mon Sep 17 00:00:00 2001 From: Armel Soro Date: Tue, 11 Feb 2025 18:12:57 +0100 Subject: [PATCH 2/4] Bump Chart version --- charts/backstage/Chart.yaml | 2 +- charts/backstage/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/backstage/Chart.yaml b/charts/backstage/Chart.yaml index a11b7be5..2fd75ef1 100644 --- a/charts/backstage/Chart.yaml +++ b/charts/backstage/Chart.yaml @@ -44,4 +44,4 @@ sources: # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 3.0.2 +version: 3.0.3 diff --git a/charts/backstage/README.md b/charts/backstage/README.md index 6acf2bc7..f1c0df8b 100644 --- a/charts/backstage/README.md +++ b/charts/backstage/README.md @@ -2,7 +2,7 @@ # RHDH Backstage Helm Chart for OpenShift (Community Version) [![Artifact Hub](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/rhdh-chart&style=flat-square)](https://artifacthub.io/packages/search?repo=rhdh-chart) -![Version: 3.0.2](https://img.shields.io/badge/Version-3.0.2-informational?style=flat-square) +![Version: 3.0.3](https://img.shields.io/badge/Version-3.0.3-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) A Helm chart for deploying Red Hat Developer Hub. From bd3c8078788d217e3230b38b7ec2617127fc0f7c Mon Sep 17 00:00:00 2001 From: Armel Soro Date: Wed, 12 Feb 2025 09:12:56 +0100 Subject: [PATCH 3/4] Catch regression by testing an in-place upgrade of each chart from its previous version MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When using the '–upgrade' flag, regression testing will only be performed if the major version of the Chart is not changed (Semver). Otherwise, normal testing will still happen. --- .github/workflows/test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index e5f96cc5..e87a4612 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -83,7 +83,7 @@ jobs: - name: Run chart-testing (latest) # test with latest stable backstage-showcase release - run: ct install --config ct-install.yaml --target-branch ${{ github.event.pull_request.base.ref }} --helm-extra-set-args="--set=upstream.backstage.image.tag=latest --set=global.clusterRouterBase=app.example.com" + run: ct install --config ct-install.yaml --upgrade --target-branch ${{ github.event.pull_request.base.ref }} --helm-extra-set-args="--set=upstream.backstage.image.tag=latest --set=global.clusterRouterBase=app.example.com" test-next: name: Test Next Release runs-on: ubuntu-latest @@ -136,4 +136,4 @@ jobs: - name: Run chart-testing (next) # test with the next backstage-showcase version (main branch) - run: ct install --config ct-install.yaml --target-branch ${{ github.event.pull_request.base.ref }} --helm-extra-set-args="--set=upstream.backstage.image.tag=next --set=global.clusterRouterBase=app.example.com" + run: ct install --config ct-install.yaml --upgrade --target-branch ${{ github.event.pull_request.base.ref }} --helm-extra-set-args="--set=upstream.backstage.image.tag=next --set=global.clusterRouterBase=app.example.com" From e035d1c66446add399b76a01d22ce0fa657c1053 Mon Sep 17 00:00:00 2001 From: Armel Soro Date: Thu, 13 Feb 2025 10:16:29 +0100 Subject: [PATCH 4/4] Bump Chart version to 3.0.4 because 3.0.3 is already taken on the main branch --- charts/backstage/Chart.yaml | 2 +- charts/backstage/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/backstage/Chart.yaml b/charts/backstage/Chart.yaml index 2fd75ef1..7fd04867 100644 --- a/charts/backstage/Chart.yaml +++ b/charts/backstage/Chart.yaml @@ -44,4 +44,4 @@ sources: # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 3.0.3 +version: 3.0.4 diff --git a/charts/backstage/README.md b/charts/backstage/README.md index f1c0df8b..cacf0264 100644 --- a/charts/backstage/README.md +++ b/charts/backstage/README.md @@ -2,7 +2,7 @@ # RHDH Backstage Helm Chart for OpenShift (Community Version) [![Artifact Hub](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/rhdh-chart&style=flat-square)](https://artifacthub.io/packages/search?repo=rhdh-chart) -![Version: 3.0.3](https://img.shields.io/badge/Version-3.0.3-informational?style=flat-square) +![Version: 3.0.4](https://img.shields.io/badge/Version-3.0.4-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) A Helm chart for deploying Red Hat Developer Hub.