chore: set NODE_OPTIONS=--no-node-snapshot env variable by default
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Kong <frkong@redhat.com>
|
3 tasks
rm3l
reviewed
May 28, 2024
There was a problem hiding this comment.
/hold
This PR might not be needed. Superseded by redhat-developer/rhdh#1277, as discussed in janus-idp/operator#366 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Now that the RHDH image runs on NodeJS 20, the
NODE_OPTIONS=--no-node-snapshotenvironmental variable is required to utilize the backstage scaffolder due to requirements fromisolated-vm.References: backstage/backstage#20661
https://github.com/laverdet/isolated-vm?tab=readme-ov-file#requirements
Existing or Associated Issue(s)
RHIDP-2436
Additional Information
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -ato apply changes.pre-commithook.ct lintcommand.