Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release-1.3): Make the dynamic plugins root PVC spec configurable [RHDHBUGS-156][RHIDP-5835] #80

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Feb 3, 2025

Description of the change

Cherry-pick of #69 into release-1.3

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@rm3l rm3l force-pushed the fix_release-1.3--make_dynamic_plugins_pvc_spec_configurable branch from b7a63bc to f14b569 Compare February 3, 2025 10:11
…DHBUGS-156][RHIDP-5573] (redhat-developer#69)

* Extract the dynamic plugins root PVC spec in a `dynamicPlugins.cache.volumeClaimSpec` field in the values file

This way, the whole PVC spec is configurable, including the storage
class name, along with other things like the PVC size and access modes.

* Bump the Chart version

* Extract the PostgreSQL PVC storageClass field to highlight that this configurable as well

See https://github.com/bitnami/charts/blob/postgresql/12.10.0/bitnami/postgresql/README.md#postgresql-primary-parameters

* Add test values file

* Regenerate README
@rm3l rm3l force-pushed the fix_release-1.3--make_dynamic_plugins_pvc_spec_configurable branch from d1d7805 to 93d74b6 Compare February 3, 2025 12:14
Copy link

sonarqubecloud bot commented Feb 3, 2025

@rm3l rm3l added the lgtm label Feb 3, 2025
@rm3l
Copy link
Member Author

rm3l commented Feb 3, 2025

Merging this cherry-pick PR - the original PR (#69) had already been approved.

@rm3l rm3l merged commit 85cc04e into redhat-developer:release-1.3 Feb 3, 2025
5 of 6 checks passed
@rm3l rm3l deleted the fix_release-1.3--make_dynamic_plugins_pvc_spec_configurable branch February 3, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant