fix: encode type and handle missing blob in Redis checkpoint writes #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aymentil, can you run all the tests locally with amend: I rebased it locally and added the same fixes to the sync implementations, I will push to the PR branch and then merge it. Great job! |
bsbodden
added a commit
that referenced
this pull request
Jun 13, 2025
This commit completes PR #57 by applying the same fixes to all four implementations of the pending_sends loading methods: - RedisSaver._load_pending_sends (sync) - ShallowRedisSaver._load_pending_sends (shallow sync) - AsyncShallowRedisSaver._aload_pending_sends (shallow async) The fixes include: 1. Using $.blob instead of blob for JSON path access 2. Using raw checkpoint_ns without to_storage_safe_str conversion 3. Encoding type to bytes with proper error handling for missing blobs Also adds comprehensive test coverage for Human-in-the-Loop functionality across all implementations.
bsbodden
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three bugs in
AsyncRedisSaver._aload_pending_sendsthat prevent Human-in-the-Loop workflows from resuming correctly with Redis checkpointers.Problem
HIL workflows work fine with InMemory saver but crash with Redis checkpointers due to:
blobinstead of$.blob)Solution
$.blobinreturn_fieldsinstead of plainblobcheckpoint_nsinstead ofto_storage_safe_str(checkpoint_ns)in filterd.type.encode()instead ofd.typeChanges
langgraph/checkpoint/redis/aio.pyinAsyncRedisSaver._aload_pending_sendsmethodTesting
Fixes #5074 link