Skip to content

Commit 74d4eda

Browse files
author
Julien Ruaux
committed
deps: Fixed conflicting dependencies
1 parent c32474f commit 74d4eda

File tree

5 files changed

+82
-23
lines changed

5 files changed

+82
-23
lines changed

build.gradle

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -73,13 +73,6 @@ subprojects {
7373
test {
7474
maxHeapSize = "1024m"
7575
}
76-
bootJar {
77-
enabled = false
78-
}
79-
jar {
80-
enabled = true
81-
archiveClassifier = ''
82-
}
8376

8477
sourceCompatibility = 8
8578
targetCompatibility = 8

gradle.properties

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,28 @@
11
group=com.redis
22

3-
bootPluginVersion=2.6.7
4-
dependencyPluginVersion=1.0.11.RELEASE
53
dockerPluginVersion=0.32.0
64
kordampBuildVersion=2.6.0
75
kordampPluginVersion=0.47.0
86

97
airliftVersion=215
108
antlrVersion=4.9.3
9+
annotationVersion=1.3.2
10+
awaitilityVersion=4.2.0
11+
errorproneVersion=2.12.0
12+
fastutilVersion=8.3.0
1113
guavaVersion=31.1-jre
1214
guiceVersion=5.1.0
1315
injectVersion=1
1416
jacksonVersion=2.13.1
17+
jnaVersion=5.10.0
18+
jodaVersion=2.10.13
1519
lettucemodVersion=2.19.3
1620
testcontainersRedisVersion=1.5.5
21+
servletVersion=4.0.1
22+
slf4jVersion=1.7.32
1723
sliceVersion=0.42
1824
trinoVersion=380
1925
ulidVersion=4.2.1
20-
unitsVersion=1.6
26+
unitsVersion=1.6
27+
validationVersion=2.0.1.Final
28+
wsVersion=2.1.1

settings.gradle

Lines changed: 38 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ buildscript {
77
dependencies {
88
classpath "org.kordamp.gradle:kordamp-parentbuild:$kordampBuildVersion"
99
classpath "org.kordamp.gradle:java-project-gradle-plugin:$kordampPluginVersion"
10-
classpath "org.springframework.boot:spring-boot-gradle-plugin:$bootPluginVersion"
11-
classpath "io.spring.gradle:dependency-management-plugin:$dependencyPluginVersion"
1210
classpath "com.palantir.gradle.docker:gradle-docker:$dockerPluginVersion"
1311
}
1412
}
@@ -30,12 +28,47 @@ projects {
3028
dirs(['subprojects']) {
3129
id 'java-library'
3230
id 'java-library-distribution'
33-
id 'org.springframework.boot'
34-
id 'io.spring.dependency-management'
3531
}
3632
}
3733
}
3834

3935
enforce {
40-
enabled = false
36+
rule(enforcer.rules.ForceDependencies) { r ->
37+
r.dependencies.addAll "com.google.guava:guava:$guavaVersion",
38+
"com.google.inject:guice:$guiceVersion",
39+
"com.google.errorprone:error_prone_annotations:$errorproneVersion",
40+
"io.airlift:units:$unitsVersion",
41+
"io.airlift:bootstrap:$airliftVersion",
42+
"io.airlift:configuration:$airliftVersion",
43+
"io.airlift:json:$airliftVersion",
44+
"io.airlift:concurrent:$airliftVersion",
45+
"io.airlift:log:$airliftVersion",
46+
"io.airlift:slice:$sliceVersion",
47+
"io.airlift:discovery:$airliftVersion",
48+
"io.airlift:event:$airliftVersion",
49+
"io.airlift:http-client:$airliftVersion",
50+
"io.airlift:http-server:$airliftVersion",
51+
"io.airlift:jaxrs:$airliftVersion",
52+
"io.airlift:jmx:$airliftVersion",
53+
"io.airlift:node:$airliftVersion",
54+
"io.airlift:trace-token:$airliftVersion",
55+
"javax.servlet:javax.servlet-api:$servletVersion",
56+
"org.slf4j:slf4j-api:$slf4jVersion",
57+
"com.fasterxml.jackson.core:jackson-annotations:$jacksonVersion",
58+
"com.fasterxml.jackson.core:jackson-core:$jacksonVersion",
59+
"com.fasterxml.jackson.core:jackson-databind:$jacksonVersion",
60+
"com.fasterxml.jackson.dataformat:jackson-dataformat-smile:$jacksonVersion",
61+
"javax.validation:validation-api:$validationVersion",
62+
"javax.annotation:javax.annotation-api:$annotationVersion",
63+
"joda-time:joda-time:$jodaVersion",
64+
"org.awaitility:awaitility:$awaitilityVersion",
65+
"org.antlr:antlr4-runtime:$antlrVersion",
66+
"it.unimi.dsi:fastutil:$fastutilVersion",
67+
"net.java.dev.jna:jna:$jnaVersion",
68+
"javax.ws.rs:javax.ws.rs-api:$wsVersion"
69+
}
70+
rule(enforcer.rules.BanDuplicateClasses) { r ->
71+
// ignore all classes under the following package
72+
r.ignore('org.hamcrest.*')
73+
}
4174
}

subprojects/trino-redisearch/src/test/java/com/redis/trino/RediSearchQueryRunner.java

Lines changed: 26 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
package com.redis.trino;
22

3-
import static io.airlift.testing.Closeables.closeAllSuppress;
4-
import static io.airlift.units.Duration.nanosSince;
53
import static io.trino.plugin.tpch.TpchMetadata.TINY_SCHEMA_NAME;
64
import static io.trino.testing.TestingSession.testSessionBuilder;
75
import static java.lang.String.format;
86
import static java.util.Locale.ENGLISH;
7+
import static java.util.Objects.requireNonNull;
98
import static java.util.concurrent.TimeUnit.SECONDS;
109

1110
import java.util.Map;
@@ -15,6 +14,8 @@
1514

1615
import io.airlift.log.Logger;
1716
import io.airlift.log.Logging;
17+
import io.airlift.testing.Closeables;
18+
import io.airlift.units.Duration;
1819
import io.trino.Session;
1920
import io.trino.metadata.QualifiedObjectName;
2021
import io.trino.plugin.tpch.TpchPlugin;
@@ -57,14 +58,34 @@ public static DistributedQueryRunner createRediSearchQueryRunner(RediSearchServe
5758
for (TpchTable<?> table : tables) {
5859
loadTpchTopic(server, trinoClient, table);
5960
}
60-
LOG.info("Loading complete in %s", nanosSince(startTime).toString(SECONDS));
61+
LOG.info("Loading complete in %s", Duration.nanosSince(startTime).toString(SECONDS));
6162
return queryRunner;
6263
} catch (Throwable e) {
63-
closeAllSuppress(e, queryRunner);
64+
Closeables.closeAllSuppress(e, queryRunner);
6465
throw e;
6566
}
6667
}
6768

69+
public static <T extends Throwable> T closeAllSuppress(T rootCause, AutoCloseable... closeables) {
70+
requireNonNull(rootCause, "rootCause is null");
71+
if (closeables == null) {
72+
return rootCause;
73+
}
74+
for (AutoCloseable closeable : closeables) {
75+
try {
76+
if (closeable != null) {
77+
closeable.close();
78+
}
79+
} catch (Throwable e) {
80+
// Self-suppression not permitted
81+
if (rootCause != e) {
82+
rootCause.addSuppressed(e);
83+
}
84+
}
85+
}
86+
return rootCause;
87+
}
88+
6889
private static void installRediSearchPlugin(RediSearchServer server, QueryRunner queryRunner,
6990
RediSearchConnectorFactory factory, Map<String, String> extraConnectorProperties) {
7091
queryRunner.installPlugin(new RediSearchPlugin(factory));
@@ -81,7 +102,7 @@ private static void loadTpchTopic(RediSearchServer server, TestingTrinoClient tr
81102
table.getTableName().toLowerCase(ENGLISH), trinoClient.getServer(), trinoClient.getDefaultSession());
82103
loader.execute(format("SELECT * from %s",
83104
new QualifiedObjectName(TPCH_SCHEMA, TINY_SCHEMA_NAME, table.getTableName().toLowerCase(ENGLISH))));
84-
LOG.info("Imported %s in %s", table.getTableName(), nanosSince(start).convertToMostSuccinctTimeUnit());
105+
LOG.info("Imported %s in %s", table.getTableName(), Duration.nanosSince(start).convertToMostSuccinctTimeUnit());
85106
}
86107

87108
public static Session createSession() {

subprojects/trino-redisearch/trino-redisearch.gradle

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,16 @@ dependencies {
1010
implementation group: 'io.airlift', name: 'json', version: airliftVersion
1111
implementation group: 'com.redis', name: 'lettucemod', version: lettucemodVersion
1212
implementation group: 'com.github.f4b6a3', name: 'ulid-creator', version: ulidVersion
13-
implementation 'javax.validation:validation-api'
14-
testImplementation group: 'com.redis.testcontainers', name: 'testcontainers-redis-junit', version: testcontainersRedisVersion
13+
implementation group: 'javax.validation', name: 'validation-api', version: validationVersion
1514
testImplementation group: 'com.redis', name: 'lettucemod', version: lettucemodVersion, classifier: 'tests'
15+
testImplementation(group: 'com.redis.testcontainers', name: 'testcontainers-redis-junit', version: testcontainersRedisVersion) {
16+
exclude group: 'com.redis', module: 'lettucemod'
17+
exclude group: 'org.junit.jupiter', module: 'junit-jupiter-api'
18+
}
19+
testImplementation group: 'io.airlift', name: 'testing', version: airliftVersion
1620
testImplementation(group: 'io.trino', name: 'trino-testing', version: trinoVersion) {
1721
exclude group: 'org.testcontainers', module: 'testcontainers-java'
18-
}
22+
}
1923
}
2024

2125
test {

0 commit comments

Comments
 (0)