Is mutex in the Pipeline struct necessary?

[ash2k]

https://github.com/go-redis/redis/blob/86f4ea13a97aef79e108c428ec121fed0d60f1d1/pipeline.go#L43

Why would someone want to use a pipeline concurrently? Seems weird. Most people pay the price of the mutex without a need for it (99%?). People who actually need to use it concurrently (1%?) can just wrap it in a mutex by hand.

I suggest to remove the mutex while v9 hasn't been released yet.

[vmihailenco]

@monkey92t any thoughts? I don't have any preferences here...

[monkey92t]

Looks like yes, I believe for 100% (not 99% 😁) of people, pipeline doesn't need mutex, we can remove it, but need to warn users that pipeline is not concurrency safe.

[monkey92t]

Also....Should we allow reuse of Pipeline?

[vmihailenco]

@monkey92t I think yes, Pipeline should be reusable. I already rely on that here

[vmihailenco]

#2351