Support TairHash commands #2743
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangbodong22011
force-pushed
the
feature-tair-hash
branch
from
36c612b to
3b58549
Compare
zeekling
reviewed
Jan 1, 2022
zeekling
reviewed
Jan 1, 2022
zeekling
reviewed
Jan 1, 2022
zeekling
reviewed
Jan 1, 2022
|
|
||
| public interface TairHashCommands { | ||
|
|
||
| long exhset(String key, String field, String value); |
There was a problem hiding this comment.
please add javadoc for redis module
zeekling
reviewed
Jan 1, 2022
| import redis.clients.jedis.tairhash.ExhincrByParams; | ||
| import redis.clients.jedis.tairhash.ExhsetParams; | ||
|
|
||
| import static org.junit.Assert.*; |
There was a problem hiding this comment.
do not use .* when import class
Co-authored-by: 小令童鞋 <lingzhaohui@zeekling.cn>
|
@yangbodong22011 Hey, That‘s a great support 👍 . But Jedis seems to be mainly supporting the redis |
|
@dengliming I asked and got neither positive nor negative response. |
|
Apparently, the current plan is to support Redis Stack commands in Jedis. And, TairHash is not part of RS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports the commands of TairHash (A redis module, similar to redis hash, but you can set expiration and version for field).
Hash that supports field expiration has always been needed by Redis users. There have been many discussions on Redis Google Groups(this) and GitHub (redis/redis#6620, redis/redis#1042, redis/redis#167).
Jedis4 already supports
RediSearchandRedisJSON, hope more Modules can be supported.Any comments or comments are welcome, thanks.