KeyT for set operations #3190
Open
KeyT for set operations #3190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvora-h
approved these changes
Apr 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3190 +/- ##
==========================================
- Coverage 91.84% 91.74% -0.11%
==========================================
Files 128 128
Lines 33232 33328 +96
==========================================
+ Hits 30523 30577 +54
- Misses 2709 2751 +42 ☔ View full report in Codecov by Sentry. |
|
@earonesty, somehow this PR ended up in conflict state. Could you, please, update it, so we merge it? Thanks! |
petyaslavova
requested changes
May 30, 2025
| @@ -3364,7 +3364,7 @@ def sinterstore( | |||
| return self.execute_command("SINTERSTORE", dest, *args) | |||
There was a problem hiding this comment.
The dest argument of sinterstore method should also be changed as it represents the name of a new set.
The same applies for sdiffstore method's dest argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Change set operation key-types to KeyT
#3189