-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fixing sentinel command response #3191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@dvora-h Can you please take a look. |
@vladvildanov Can you please take a look ? |
@mahigupta Thanks for your input! I'll also include @gerzse into this |
Hello, |
@mahigupta Looks fine 👌 Working on fixing CI, docker-compose was removed from default commands in Ubuntu 22.04 LTS runner |
@vladvildanov @gerzse Ci fixed now to go ahead with this PR ? |
This change will still need a few new unit tests to be added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the behavior of the sentinel command response in Redis by updating the execute_command function to correctly parse responses and returning either a boolean or the original response based on the provided options.
- Updates in both synchronous and asynchronous sentinel modules to pop "once" and "return_responses" from kwargs and return the processed response.
- Updates to the Redis commands for sentinel to pass the new execution options.
- An update to the CHANGES file documenting the fix.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
redis/sentinel.py | Updated execute_command to handle return_responses and once logic. |
redis/commands/sentinel.py | Modified sentinel command method calls to include new options. |
redis/asyncio/sentinel.py | Asynchronous execute_command updated similar to its sync counterpart. |
CHANGES | Documented the fix for the sentinel command response behavior. |
…e type for sentinel's execute_command
Pull Request check-list
Description of change
For #3139
execute_command
function to parse sentinel command response correctly and don't return by default True