Fix azure_blob_storage input missing blobs #3294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockwotj
approved these changes
Mar 26, 2025
Fixes #3189, or so I hope... This also updates the Azure dependencies. Annoyingly, the original CosmosDB emulator doesn't have an ARM-based container and the new one ([`mcr.microsoft.com/cosmosdb/linux/azure-cosmos-emulator:vnext-preview`](https://learn.microsoft.com/en-us/azure/cosmos-db/emulator-linux)) has some gaps which break the existing tests such as: Azure/azure-cosmos-db-emulator-docker#182. Signed-off-by: Mihai Todor <todormihai@gmail.com>
This is a refinement of the fix in #3221. I somehow missed that the warning message would only get printed for a single discovered object since we could get multiple paths from SQS, but we only send a single ack after all the objects are processed. Signed-off-by: Mihai Todor <todormihai@gmail.com>
mihaitodor
force-pushed
the
mihaitodor-fix-azure-blob-storage-input-missing-blobs
branch
from
0459a98 to
ee8e961
Compare
mihaitodor
deleted the
mihaitodor-fix-azure-blob-storage-input-missing-blobs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3189, or so I hope...
This also updates the Azure dependencies.
Annoyingly, the original CosmosDB emulator doesn't have an ARM-based container and the new one (
mcr.microsoft.com/cosmosdb/linux/azure-cosmos-emulator:vnext-preview) has some gaps which break the existing tests such as: Azure/azure-cosmos-db-emulator-docker#182.