Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Extract RTKQ or RTK core from @reduxjs/toolkit package #4894

Open
TheWirv opened this issue Mar 14, 2025 · 3 comments
Open

Discussion: Extract RTKQ or RTK core from @reduxjs/toolkit package #4894

TheWirv opened this issue Mar 14, 2025 · 3 comments

Comments

@TheWirv
Copy link

TheWirv commented Mar 14, 2025

Hi guys, I have been using RTK basically since its inception, and plain Redux with manually written reducers, actions and action creators even before that. I have been updating RTK constantly to stay uptodate with all potential bugfixes and improvements, but I also have been noticing that new releases almost exclusively target RTKQ. That does make sense, given that the core RTK functionality works, and there's presumably nothing more to add to it (after all, "never change a running system"). But I don't use RTKQ, we have our own implementation for data fetching and storing. In return, this means that when going through my package.json to update packages, when looking for RTK updates, I have to take the time to go through the releases (and also update my dependency), just to have more code and functionality that I don't use.

In this regard, I would like to ask the team to at least consider extracting RTKQ (or RTK core, maybe that makes more sense from a maintenance perspective) into its own separate package, so that users who have no need for the Query functionality save time and space.

Thanks for reading.
Marcel

@TheWirv TheWirv changed the title Discussion: Extract RTKQ from @reduxjs/toolkit package Discussion: Extract RTKQ or RTK core from @reduxjs/toolkit package Mar 14, 2025
@phryneas
Copy link
Member

phryneas commented Mar 14, 2025

Other users might not use entity adapters, or the listener middleware.
It's a toolkit with the most commonly used tools, and it is generally very unlikely that everyone uses everything - but we put them into one package, because it has been a very common complaint that to use Redux you had to install half a dozen packages.

Generally: we stick to SemVer. If it's a patch, you probably don't need to read the changelog, if it's a minor you just need to skim it (we will call anything potentially disrupting at the top), and we only had one major in the whole 5 years RTK exists. I don't think that's too much noise.

@TheWirv
Copy link
Author

TheWirv commented Mar 14, 2025

I understand your point, but I think it's an unfair comparison, considering that RTKQ has almost been the sole focus of major development over the past months, if not years.

And sorry, but no, even though I trust the SemVer system generally, I won't just install any update without knowing at least on a surface level what has changed. And I doubt that many developers working on an at least half-serious project would do that.

@phryneas
Copy link
Member

I understand your point, but I think it's an unfair comparison, considering that RTKQ has almost been the sole focus of major development over the past months, if not years.

While it might be invisible to you, the biggest chunk of work of the last two years did not go into RTK Query, but into the bundling story that was rolled out in 2.0 and revised in 2.2.

And sorry, but no, even though I trust the SemVer system generally, I won't just install any update without knowing at least on a surface level what has changed. And I doubt that many developers working on an at least half-serious project would do that.

That's of course up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants