Release 0.33.11

Release 0.33.11

.github/workflows/pr-dev.yml

@@ -90,11 +90,8 @@ jobs:
     runs-on: ubuntu-latest
     needs: buildAndTest
     if: |
-      startsWith(github.head_ref, 'feature/')
-      || startsWith(github.head_ref, 'maintenance/')
-      || startsWith(github.head_ref, 'hotfix/')
-      || startsWith(github.head_ref, 'fix/')
-      || startsWith(github.head_ref, 'bugfix/')
+      !startsWith(github.head_ref, 'docs/') &&
+      !startsWith(github.head_ref, 'service/')
     services:
       postgres:
         image: clkao/postgres-plv8:10-2
@@ -177,10 +174,8 @@ jobs:
     runs-on: ubuntu-latest
     needs: buildAndTest
     if: |
-      startsWith(github.head_ref, 'feature/')
-      || startsWith(github.head_ref, 'hotfix/')
-      || startsWith(github.head_ref, 'fix/')
-      || startsWith(github.head_ref, 'bugfix/')
+      !startsWith(github.head_ref, 'docs/') &&
+      !startsWith(github.head_ref, 'service/')
     steps:
       - uses: actions/checkout@v2
 
@@ -246,10 +241,8 @@ jobs:
     needs: buildAndTest
     concurrency: cloud-environment
     if: |
-      startsWith(github.head_ref, 'feature/')
-      || startsWith(github.head_ref, 'hotfix/')
-      || startsWith(github.head_ref, 'fix/')
-      || startsWith(github.head_ref, 'bugfix/')
+      !startsWith(github.head_ref, 'docs/') &&
+      !startsWith(github.head_ref, 'service/')
     steps:
       - uses: actions/checkout@v2
 
@@ -394,11 +387,7 @@ jobs:
     runs-on: ubuntu-latest
     needs: buildAndTest
     if: |
-      startsWith(github.head_ref, 'feature/')
-      || startsWith(github.head_ref, 'hotfix/')
-      || startsWith(github.head_ref, 'fix/')
-      || startsWith(github.head_ref, 'bugfix/')
-      || startsWith(github.head_ref, 'docs/')
+      !startsWith(github.head_ref, 'service/')
     steps:
       - uses: actions/checkout@v2
 

CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## [Upcoming](https://github.com/reimagined/resolve/tree/HEAD)
+
+[Full Changelog](https://github.com/reimagined/resolve/compare/V0.33.10...HEAD)
+
+**Enhancements:**
+
+- Prechecked notifications [\#2209](https://github.com/reimagined/resolve/pull/2209)
+- Implement sort index hints for postgres eventstore [\#2204](https://github.com/reimagined/resolve/pull/2204)
+
+**Bug fixes:**
+
+- Too many connections created during the startup of hacker-news example with custom read-models enabled [\#2123](https://github.com/reimagined/resolve/issues/2123)
+
 ## [V0.33.10](https://github.com/reimagined/resolve/tree/V0.33.10) (2022-01-17)
 
 [Full Changelog](https://github.com/reimagined/resolve/compare/V0.33.9...V0.33.10)

examples/ts/hacker-news/package.json

@@ -80,6 +80,7 @@
     "@types/isomorphic-fetch": "0.0.35",
     "@types/jest": "26.0.23",
     "@types/jsonwebtoken": "8.5.4",
+    "@types/history": "4.7.11",
     "@types/node": "14.17.5",
     "@types/passport-local": "1.0.34",
     "@types/progress": "2.0.5",

examples/ts/personal-data/package.json

@@ -59,6 +59,7 @@
     "@resolve-js/scripts": "0.33.10",
     "@types/crypto-js": "4.0.2",
     "@types/jest": "26.0.23",
+    "@types/history": "4.7.11",
     "@types/node": "14.17.5",
     "@types/react": "17.0.5",
     "@types/react-dom": "17.0.5",

examples/ts/shopping-list-redux-hoc/package.json

@@ -58,6 +58,7 @@
     "@resolve-js/scripts": "0.33.10",
     "@resolve-js/testing-tools": "0.33.10",
     "@types/jest": "26.0.23",
+    "@types/history": "4.7.11",
     "@types/node": "14.17.5",
     "@types/react": "17.0.5",
     "@types/react-dom": "17.0.5",

examples/ts/shopping-list-redux/package.json

@@ -58,6 +58,7 @@
     "@resolve-js/scripts": "0.33.10",
     "@resolve-js/testing-tools": "0.33.10",
     "@types/jest": "26.0.23",
+    "@types/history": "4.7.11",
     "@types/node": "14.17.5",
     "@types/react": "17.0.5",
     "@types/react-dom": "17.0.5",

examples/ts/shopping-list/package.json

@@ -52,6 +52,7 @@
     "@resolve-js/scripts": "0.33.10",
     "@resolve-js/testing-tools": "0.33.10",
     "@types/jest": "26.0.23",
+    "@types/history": "4.7.11",
     "@types/node": "14.17.5",
     "@types/react": "17.0.5",
     "@types/react-dom": "17.0.5",

packages/runtime/adapters/eventstore-adapters/eventstore-postgresql/src/create-load-query.ts

@@ -36,20 +36,26 @@ const createLoadQuery = (
 
   if (limit !== undefined) {
     return [
-      `SELECT "unitedEvents".* FROM (
-        ${vectorConditions
-          .map(
-            (threadCounter, threadId) =>
-              `(${[
-                `SELECT * FROM ${databaseNameAsId}.${eventsTableAsId}`,
-                `WHERE (${resultQueryCondition}) AND "threadId" = ${threadId} AND "threadCounter" >= ${threadCounter}::${INT8_SQL_TYPE}`,
-                `LIMIT ${limit}`,
-              ].join(' ')})`
-          )
-          .join(' UNION ALL \n')}
-        ) "unitedEvents"`,
-      `ORDER BY "unitedEvents"."timestamp" ASC, "unitedEvents"."threadCounter" ASC, "unitedEvents"."threadId" ASC`,
-      `LIMIT ${+limit}`,
+      `SELECT "sortedEvents".* FROM (`,
+      `  SELECT "unitedEvents".* FROM (`,
+      vectorConditions
+        .map(
+          (threadCounter, threadId) =>
+            `(${[
+              `SELECT * FROM ${databaseNameAsId}.${eventsTableAsId}`,
+              `WHERE (${resultQueryCondition}) AND "threadId" = ${threadId} AND "threadCounter" >= ${threadCounter}::${INT8_SQL_TYPE}`,
+              `ORDER BY "threadCounter" ASC`,
+              `LIMIT ${limit}`,
+            ].join(' ')})`
+        )
+        .join(' UNION ALL \n'),
+      `  ) "unitedEvents"`,
+      `  ORDER BY "unitedEvents"."timestamp" ASC`,
+      `  LIMIT ${+limit}`,
+      `) "sortedEvents"`,
+      `ORDER BY "sortedEvents"."timestamp" ASC,`,
+      `"sortedEvents"."threadCounter" ASC,`,
+      `"sortedEvents"."threadId" ASC`,
     ].join('\n')
   } else {
     const resultVectorConditions = `${vectorConditions

packages/runtime/runtimes/runtime-base/src/bootstrap-one.ts

@@ -7,7 +7,6 @@ export const bootstrapOne = async ({
   eventstoreAdapter,
   eventSubscriber,
   eventTypes,
-  destination,
   upstream,
   ensureQueue,
   forceResume,
@@ -17,7 +16,6 @@ export const bootstrapOne = async ({
   eventstoreAdapter: Runtime['eventStoreAdapter']
   eventSubscriber: Runtime['eventSubscriber']
   eventTypes: string[]
-  destination?: string
   upstream: EventListenersManagerParameters['upstream']
   ensureQueue: EventListenersManagerParameters['ensureQueue']
   forceResume: boolean
@@ -31,19 +29,6 @@ export const bootstrapOne = async ({
       errors.push(err)
     }
 
-    try {
-      log.debug(`ensuring event subscriber`)
-      await eventstoreAdapter.ensureEventSubscriber({
-        applicationName,
-        eventSubscriber: name,
-        status: null,
-        destination,
-      })
-    } catch (err) {
-      log.error(err)
-      errors.push(err)
-    }
-
     try {
       log.debug(`subscribing`)
       await eventSubscriber.subscribe({

packages/runtime/runtimes/runtime-base/src/bootstrap.ts

@@ -23,13 +23,7 @@ export const bootstrap = async (
   waitForReady: boolean
 ) => {
   log.debug('bootstrap started')
-  const {
-    upstream,
-    eventSubscriberScope,
-    getEventSubscriberDestination,
-    ensureQueue,
-    deleteQueue,
-  } = params
+  const { upstream, eventSubscriberScope, ensureQueue, deleteQueue } = params
   const { eventSubscriber, eventStoreAdapter, eventListeners } = runtime
 
   const promises = []
@@ -43,7 +37,6 @@ export const bootstrap = async (
         eventSubscriber,
         name,
         eventTypes,
-        destination: getEventSubscriberDestination(name),
         upstream,
         ensureQueue,
         forceResume: waitForReady,

packages/runtime/runtimes/runtime-base/src/create-runtime.ts

@@ -202,10 +202,19 @@ export const createRuntime = async (
     readModels: domain.readModels,
   })
 
+  const {
+    getEventSubscriberDestination,
+    deleteQueue,
+    ensureQueue,
+    upstream,
+    uploader,
+  } = params
+
   const executeQuery = createQueryExecutor({
     invokeBuildAsync,
     applicationName: eventSubscriberScope,
     eventstoreAdapter: eventStoreAdapter,
+    getEventSubscriberDestination,
     readModelConnectors,
     loadReadModelProcedure,
     performanceTracer,
@@ -224,8 +233,6 @@ export const createRuntime = async (
     }),
   })
 
-  const { uploader } = params
-
   const getScheduler = () => {
     if (params.scheduler != null) {
       log.debug(`actual scheduler bound`)
@@ -241,6 +248,7 @@ export const createRuntime = async (
     executeCommand,
     executeQuery,
     eventstoreAdapter: eventStoreAdapter,
+    getEventSubscriberDestination,
     secretsManager,
     readModelConnectors,
     performanceTracer,
@@ -258,13 +266,6 @@ export const createRuntime = async (
     eventListeners,
   })
 
-  const {
-    deleteQueue,
-    ensureQueue,
-    getEventSubscriberDestination,
-    upstream,
-  } = params
-
   const eventListenersManager = eventListenersManagerFactory(
     {
       eventSubscriber,
@@ -276,7 +277,6 @@ export const createRuntime = async (
       eventSubscriberScope,
       deleteQueue,
       ensureQueue,
-      getEventSubscriberDestination,
     }
   )
 

packages/runtime/runtimes/runtime-base/src/event-broadcast-factory.ts

@@ -42,9 +42,22 @@ export const broadcaster = async (
         continue
       }
       promises.push(
-        runtime.invokeBuildAsync(
-          createEventSubscriberNotification(eventSubscriber, event)
-        )
+        (async () => {
+          let isAlreadyBuilding = false
+          try {
+            isAlreadyBuilding = !!(
+              await (runtime as any).eventSubscriber.status({
+                eventSubscriber,
+                includeRuntimeStatus: true,
+              })
+            ).isAlive
+          } catch (e) {}
+          if (!isAlreadyBuilding) {
+            await runtime.invokeBuildAsync(
+              createEventSubscriberNotification(eventSubscriber, event)
+            )
+          }
+        })()
       )
     }
 

packages/runtime/runtimes/runtime-base/src/query/types.ts

@@ -18,6 +18,7 @@ import type {
 } from '../types'
 
 export type CreateQueryOptions = {
+  getEventSubscriberDestination: (name: string) => string
   invokeBuildAsync: InvokeBuildAsync
   readModelConnectors: Record<string, ReadModelConnector>
   performanceTracer: PerformanceTracer | null
@@ -51,6 +52,7 @@ export type SerializedError = {
 
 export type ReadModelPool = {
   performanceTracer: CreateQueryOptions['performanceTracer']
+  getEventSubscriberDestination: (name: string) => string
   isDisposed: boolean
   connector: ReadModelConnector
   connections: Set<any>