Change artwork lookup to fanart.tv #3213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add config for last.fm api key and musicbrainz useragent customization
add debug logging for musicbrainz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes artwork lookup from last.fm to fanart.tv
last.fm changed their API so artwork can no longer be pulled.
The smallest images from fanart.tv are 200x200px. The full image size for Album pages are 200x200px so both thumb and full size are the same image source from fanart.tv. The "full size" image is only downloaded when you click on the album detail link.
When the album cache is too old, Headphones will do an artwork lookup. Since most people's cache is probably expired, we're hammering the last.fm API with artwork requests that will never work. This change will also hopefully stop that and prevent us from triggering the last.fm API limit.