-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add integration test #169
add integration test #169
Conversation
✅ Deploy Preview for monaco-yaml ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have wanted to add tests for a long time. This really helps a lot! ❤️
I have some small comments, but overall this looks great!
@mhsdesign we may want to add tests for |
Thanks for the effort @domsew will look into it |
I merged it, because it’s already good as-is. I have one follow-up question: Can we get code coverage? I understand this may be complex, given that we build a test project from already bundled sources. |
I believe it is possible and in fact this is a great idea. |
Hello,
I prepared POC of integration test (due to #26). This test checks if syntax checking works, which proves that
monaco-editor
works withyaml-language-server
as expected (which is the main goal ofmonaco-yaml
). I used playwright. To run test:npm i
npx playwright install
npm run test
npx playwright test --config=test/playwright.config.ts --headed
Let me know if you like it and what can be improved.