Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix coupled tests #1998

Merged
merged 2 commits into from
Feb 20, 2025
Merged

fix coupled tests #1998

merged 2 commits into from
Feb 20, 2025

Conversation

orichters
Copy link
Contributor

Purpose of this PR

  • somehow, the renv folder requires force = TRUE to be deleted
  • also compile the third scenario
  • correctly identify which files should be present and only then delete all.

Type of change

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I checked the log.txt file of my runs for newly introduced summation, fixing or variable name errors
  • All automated model tests pass, executed after my final commit (FAIL 0 in the output of make test-coupled)
  • The changelog CHANGELOG.md has been updated correctly

@orichters orichters requested a review from dklein-pik February 20, 2025 12:31
Co-authored-by: David Klein <dklein@pik-potsdam.de>
@orichters orichters merged commit b63516b into remindmodel:develop Feb 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants