Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vm_emiCdrAll and adjustments to industry emi variables #2004

Merged
merged 14 commits into from
Feb 28, 2025

Conversation

tabeado
Copy link
Contributor

@tabeado tabeado commented Feb 25, 2025

Purpose of this PR

This PR updates the total CDR variable vm_emiCdrAll which is necessary for the new implementation of the net negative emissions tax.
As part of this, it changes the following in 37_industry:

  • rename v37_emiNonFosNonIncineratedPlastics to vm_emiNonFosNonIncineratedPlastics => needs to be changed with parallel PR in remind2
  • added vm_nonFosPlastic_incinCC for simpler code, is used once in 37_industry and in core for calculation of vm_emiCdrAll
  • added vm_nonFosNonPlastic_landfilled to avoid renaming of 3 parameters & variables, is used once in 37_industry and in core for calculation of vm_emiCdrAll

Other changes:

  • adding v_ccsShare, i.e. the share of captured carbon stored geologically
  • improvement of descriptions of in 37_industry and core

#Type of change

  • Refactoring
  • Minor change (default scenarios show only small differences)

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I checked the log.txt file of my runs for newly introduced summation, fixing or variable name errors
  • All automated model tests pass, executed after my final commit (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Further information (optional):

  • Runs with these changes are here: /p/tmp/tabeado/remind_CdrVariable/remind
  • Comparison of results (what changes by this PR?): see comments

@tabeado
Copy link
Contributor Author

tabeado commented Feb 25, 2025

Test runs for default PB650 settings show deviations in EUR & some in NEU for waste emissions. I can't figure out what change in the calculation would cause this, but maybe you can @JakobBD?
image
image
image

@@ -663,7 +663,7 @@ q_emiAllMkt(t,regi,emi,emiMkt) ..
macSector2emiMkt(emiMacSector,emiMkt)),
vm_emiMacSector(t,regi,emiMacSector)
)
!! CDR from CDR module
!! emissions from CDR module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked "CDR from CDR module" as "emissions" kinda suggest that this is all emissions from the module, also including energy related and process emissions. But I don't have too strong opinions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But CDR is wrong for dac... I prefer emissions because it's really all actual emissions that are calculated directly in the CDR module (incl. non-captured emi from calcination + energy). Energy-related emissions are not calculated there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahaha sorry. I restructured this part in my PR, because I want to keep energy related emissions and active removal from the atmosphere separate. So after that it will be CDR from CDR module and not emissions. I'm already so familiar with my restructured version that I didn't realise that it was an inconsistency in the trunk.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think CDR would be misleading, since it is all captured dac emissions, but not all of that is necessarily daccs. My point is not about the FE emissions, but about dac vs daccs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I totally see your point and honestly, go for whatever you want, my opinion isn't that strong. But "emissions from CDR module" for me implies that it does contain FE or calcination emissions.
How about a longer explanation?
Theoretical max. of removals from CDR module before rerelease from CCU ?

- sum((emi,emiMkt),
vm_emiNonFosNonIncineratedPlastics(t,regi,emi,emiMkt)) !! negative value
!! 2c) non-plastics materials CDR -- landfilled waste from non-fossil feedstocks
+ vm_nonFosNonPlastic_landfilled(t,regi) !! positive value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks very good to me. After my PR (still the old draft version, will update hopefully tonight) to restructure the accounting of energy related carbon capture in module 33 I will add this super small addition (CDR from FE+CCS in the CDR module) total CDR here too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add this to this PR / send me the code / add it later?

Copy link
Contributor

@amerfort amerfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. The CDR part looks good, but I don't feel confident enough to judge the changes in the Industry module.

Copy link
Contributor

@JakobBD JakobBD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the differences in the plots, I don't know, but I'd guess that it could be conopt imprecisions/random deviations in a quite flat optimum. Especially since it only occurs spuriously in a few regions.

@tabeado tabeado marked this pull request as ready for review February 27, 2025 15:46
@tabeado tabeado merged commit db55b6e into remindmodel:develop Feb 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants