-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vm_emiCdrAll and adjustments to industry emi variables #2004
Conversation
Test runs for default PB650 settings show deviations in EUR & some in NEU for waste emissions. I can't figure out what change in the calculation would cause this, but maybe you can @JakobBD? |
core/equations.gms
Outdated
@@ -663,7 +663,7 @@ q_emiAllMkt(t,regi,emi,emiMkt) .. | |||
macSector2emiMkt(emiMacSector,emiMkt)), | |||
vm_emiMacSector(t,regi,emiMacSector) | |||
) | |||
!! CDR from CDR module | |||
!! emissions from CDR module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked "CDR from CDR module" as "emissions" kinda suggest that this is all emissions from the module, also including energy related and process emissions. But I don't have too strong opinions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But CDR is wrong for dac... I prefer emissions because it's really all actual emissions that are calculated directly in the CDR module (incl. non-captured emi from calcination + energy). Energy-related emissions are not calculated there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahaha sorry. I restructured this part in my PR, because I want to keep energy related emissions and active removal from the atmosphere separate. So after that it will be CDR from CDR module and not emissions. I'm already so familiar with my restructured version that I didn't realise that it was an inconsistency in the trunk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think CDR would be misleading, since it is all captured dac emissions, but not all of that is necessarily daccs. My point is not about the FE emissions, but about dac vs daccs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I totally see your point and honestly, go for whatever you want, my opinion isn't that strong. But "emissions from CDR module" for me implies that it does contain FE or calcination emissions.
How about a longer explanation?
Theoretical max. of removals from CDR module before rerelease from CCU
?
core/equations.gms
Outdated
- sum((emi,emiMkt), | ||
vm_emiNonFosNonIncineratedPlastics(t,regi,emi,emiMkt)) !! negative value | ||
!! 2c) non-plastics materials CDR -- landfilled waste from non-fossil feedstocks | ||
+ vm_nonFosNonPlastic_landfilled(t,regi) !! positive value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks very good to me. After my PR (still the old draft version, will update hopefully tonight) to restructure the accounting of energy related carbon capture in module 33 I will add this super small addition (CDR from FE+CCS in the CDR module) total CDR here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to add this to this PR / send me the code / add it later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. The CDR part looks good, but I don't feel confident enough to judge the changes in the Industry module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the differences in the plots, I don't know, but I'd guess that it could be conopt imprecisions/random deviations in a quite flat optimum. Especially since it only occurs spuriously in a few regions.
Co-authored-by: Jakob Duerrwaechter <44020564+JakobBD@users.noreply.github.com>
Purpose of this PR
This PR updates the total CDR variable
vm_emiCdrAll
which is necessary for the new implementation of the net negative emissions tax.As part of this, it changes the following in 37_industry:
v37_emiNonFosNonIncineratedPlastics
tovm_emiNonFosNonIncineratedPlastics
=> needs to be changed with parallel PR in remind2vm_nonFosPlastic_incinCC
for simpler code, is used once in 37_industry and in core for calculation of vm_emiCdrAllvm_nonFosNonPlastic_landfilled
to avoid renaming of 3 parameters & variables, is used once in 37_industry and in core for calculation of vm_emiCdrAllOther changes:
v_ccsShare
, i.e. the share of captured carbon stored geologically#Type of change
Checklist:
remind2
where it was neededforbiddenColumnNames
in readCheckScenarioConfig.R in case the PR leads to deprecated switcheslog.txt
file of my runs for newly introduced summation, fixing or variable name errorsFAIL 0
in the output ofmake test
)CHANGELOG.md
has been updated correctlyFurther information (optional):
/p/tmp/tabeado/remind_CdrVariable/remind