Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remoteaccess connect ssh handling of empty port-forwarding options #427

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

reubenmiller
Copy link
Owner

@reubenmiller reubenmiller commented Jan 29, 2025

Fixing a bug where the remoteaccess port-forwarding option was not ignore empty values (which is the default) and it was resulting in an invalid ssh command.

This resulted in the following command failing as shown below:

$ c8y remoteaccess connect ssh --device rpi5-abcdef --user pi

2025-01-29T09:27:02.994+0100	INFO	Executing command: ssh -o ServerAliveInterval=120 -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -p 59380 root@127.0.0.1 -L :127.0.0.1:

Starting interactive ssh session with 5733465816 (https://myiot.example.cumulocity.com) with port-forwarding :127.0.0.1:

Bad local forwarding specification ':127.0.0.1:'
Duration: 26m

@reubenmiller reubenmiller merged commit 9ec2335 into v2 Jan 29, 2025
4 checks passed
@reubenmiller reubenmiller deleted the fix-remoteaccess-ssh branch January 29, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant