Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env Variable Support #302

Closed
wants to merge 9 commits into from
Closed

Env Variable Support #302

wants to merge 9 commits into from

Conversation

Rushmore75
Copy link

  • I understand and have followed the contribution guide
  • I have tested my changes locally and they are working as intended

Add support for more environment variables in a similar fashion to how to old system works.
revoltchat/self-hosted#90 Is related, it shows the .env config already.

(The fact that my branch is called docker is because it was going to be to dockerize this, then I realized that the self-host stack already has Caddy in it so that can be used to host the dist folder)

Signed-off-by: Rushmore75 <oliveratkinsoneng@gmail.com>
Signed-off-by: Rushmore75 <oliveratkinsoneng@gmail.com>
Signed-off-by: Rushmore75 <oliveratkinsoneng@gmail.com>
Signed-off-by: Rushmore75 <oliveratkinsoneng@gmail.com>
Signed-off-by: Rushmore75 <oliveratkinsoneng@gmail.com>
@insertish
Copy link
Member

I'm not sure what's going on with this and #301, but there's a lot of unrelated changes strewn about.
You may want to re-create your PRs to only modify what you're intending to modify.

@Rushmore75
Copy link
Author

It's pretty much just changing the environment variables to more specific ones, instead of using one env variable for the whole project for url

Then updating the Readme so it reflects the changes + removing parts of the Readme where it references repos that no longer exist

Also fixing a file name for an svg that no longer exists

Also fixing the package.json to have a command to build for pro

@insertish
Copy link
Member

Closing out as a lot of these changes are unneeded, break process, or break production deployment (which some of these commands are only intended for).

@insertish insertish closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants