⚡️ Adding msg.sender separation for factory calls #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroknots
commented
Apr 18, 2024
src/core/ModuleManager.sol
Outdated
| @@ -34,6 +60,12 @@ abstract contract ModuleManager is IRegistry, ResolverManager { | |||
|
|
|||
| mapping(address moduleAddress => ModuleRecord moduleRecord) internal $moduleAddrToRecords; | |||
|
|
|||
| FactoryTrampolin private immutable FACTORY_TRAMPOLIN; | |||
There was a problem hiding this comment.
should I make this public? could be helpful if specialized factories want to do access control for the trampolin. would be better devex?!
zeroknots
force-pushed
the
feature/factory-call
branch
from
de456f8 to
4af3776
Compare
zeroknots
commented
Apr 18, 2024
src/core/ModuleManager.sol
Outdated
| moduleAddress = abi.decode(returnData, (address)); | ||
| // Call the factory via the trampolin contract. This will make sure that there is msg.sender separation | ||
| // Making "raw" calls to user supplied addresses could create security issues. | ||
| moduleAddress = FACTORY_TRAMPOLIN.deployViaFactory{ value: msg.value }({ factory: factory, callOnFactory: callOnFactory }); |
There was a problem hiding this comment.
TODO: should write test that msg.value is correctly passed through
Co-authored-by: Konrad <kopp.konrad@gmail.com>
Co-authored-by: Konrad <kopp.konrad@gmail.com>
Co-authored-by: Konrad <kopp.konrad@gmail.com>
Co-authored-by: Konrad <kopp.konrad@gmail.com>
Co-authored-by: Konrad <kopp.konrad@gmail.com>
Co-authored-by: Konrad <kopp.konrad@gmail.com>
Co-authored-by: Konrad <kopp.konrad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is a vulnerability outright. But I could imagine that some business logic in resolvers in the future could be triggered by this.