Feature: update packages version && loosely coupled rules (#22)

* chore: update package versions * feature: better settings for environments * fix: eleminiate duplicate rules * REVERT: package version * chore: update CHANGELOG * review: remove base.js * review: fix rule according to a company rule * chore: update README * review: update README
ridi · Sep 14, 2020 · eff9562 · eff9562
1 parent 1a9fdf1
commit eff9562
Show file tree

Hide file tree

Showing 8 changed files with 361 additions and 145 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,6 @@
 ## master
+### Changed
+- Feature: update packages version && loose coupled rules ([#22](https://github.com/ridi/eslint-config/pull/22))
 
 ## v5.0.0 - 2020-07-02
 ### Changed

diff --git a/README.md b/README.md
@@ -21,41 +21,58 @@ yarn --dev eslint @ridi/eslint-config
 
 ## Usage
 
-#### Default (airbnb based, outdated)
-
+### Javascript
 ```javascript
-{
-  "extends": "@ridi",
-  "rules": {
-    // exceptions
-  }
+module.exports = {
+  extends: [
+    '@ridi/eslint-config'
+  ]
 }
 ```
 
-#### Typescript
+### @ridi/eslint-config/typescript
+> * @typescript-eslint/eslint-plugin
 
-```js
-{
-  "extends": [
-    "@ridi/eslint-config/typescript",
-  ],
+
+#### Typescript
+```javascript
+module.exports = {
+  extends: [
+    '@ridi/eslint-config',
+    '@ridi/eslint-config/typescript'
+  ]
 }
 ```
-> * @typescript-eslint/eslint-plugin
 
-#### React
+### @ridi/eslint-config/react
+> * eslint-plugin-import
+> * eslint-plugin-jsx-a11y
+> * eslint-plugin-react
+> * eslint-plugin-react-hooks
 
+#### Javascript + React
 ```js
 {
   "extends": [
+    '@ridi/eslint-config',
     "@ridi/eslint-config/react",
   ],
 }
 ``` 
-> * eslint-plugin-import
-> * eslint-plugin-jsx-a11y
-> * eslint-plugin-react
-> * eslint-plugin-react-hooks
+
+
+#### Typescript + React
+```javascript
+module.exports = {
+  extends: [
+    '@ridi/eslint-config',
+    '@ridi/eslint-config/typescript'
+    '@ridi/eslint-config/react'
+  ]
+}
+```
+### @ridi/eslint-config/prettier
+> * eslint-plugin-prettier
 
 #### Prettier
 
@@ -64,8 +81,12 @@ works fine with local configuration file (e.g. .prettierrc)
 ```js
 {
   "extends": [
+    '@ridi/eslint-config',
     "@ridi/eslint-config/prettier",
   ],
 }
 ```
-> * eslint-plugin-prettier
+
+
+
+
diff --git a/index.js b/index.js
@@ -1,5 +1,12 @@
 module.exports = {
-  extends: 'airbnb',
+  env: {
+    es2020: true,
+  },
+  extends: ['eslint:recommended', 'airbnb-base'],
+  parserOptions: {
+    ecmaVersion: 11,
+    sourceType: 'module',
+  },
   rules: {
     // 프로퍼티 이름은 camelCase를 강제하지 않음
     // 참고: https://github.com/ridi/style-guide/blob/master/API.md#user-content-http-api-작성-가이드
@@ -13,9 +20,5 @@ module.exports = {
 
     // 문장의 마지막에 존재하는 주석 시작 전에 한 개 이상의 공백을 허용
     'no-multi-spaces': ['error', { ignoreEOLComments: true }],
-
-    // `<label>` 태그가 컨트롤을 반드시 포함하지 않아도 됨
-    // 참고: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/label-has-for.md
-    'jsx-a11y/label-has-for': ['error', { required: 'id' }],
   },
 };
diff --git a/package.json b/package.json
@@ -23,30 +23,30 @@
     "ridi",
     "javascript"
   ],
-  "author": "",
+  "author": "RIDI",
   "license": "MIT",
   "bugs": {
     "url": "https://github.com/ridi/eslint-config/issues"
   },
   "homepage": "https://github.com/ridi/eslint-config#readme",
   "dependencies": {
-    "@typescript-eslint/parser": "^3.4.0",
+    "@typescript-eslint/parser": "^4.1.0",
     "babel-eslint": "^10.1.0",
-    "eslint": "^7.3.1",
+    "eslint": "^7.9.0",
     "eslint-config-airbnb": "^18.2.0",
     "eslint-config-prettier": "^6.11.0"
   },
   "devDependencies": {
-    "@typescript-eslint/eslint-plugin": "^3.4.0",
-    "eslint-plugin-babel": "^5.3.0",
-    "eslint-plugin-import": "^2.21.2",
+    "@typescript-eslint/eslint-plugin": "^4.1.0",
+    "eslint-plugin-babel": "^5.3.1",
+    "eslint-plugin-import": "^2.22.0",
     "eslint-plugin-jsx-a11y": "^6.3.1",
     "eslint-plugin-prettier": "^3.1.4",
-    "eslint-plugin-react": "^7.20.0",
-    "eslint-plugin-react-hooks": "^4.0.4",
-    "prettier": "^2.0.5",
+    "eslint-plugin-react": "^7.20.6",
+    "eslint-plugin-react-hooks": "^4.1.2",
+    "prettier": "^2.1.1",
     "react": "^16.13.1",
-    "typescript": "^3.9.5"
+    "typescript": "^4.0.2"
   },
   "peerDependencies": {
     "eslint": ">= 3"

diff --git a/prettier.js b/prettier.js
@@ -1,6 +1,5 @@
 module.exports = {
   extends: [
-    'eslint:recommended',
     'prettier',
     'prettier/@typescript-eslint',
     'prettier/babel',

diff --git a/react.js b/react.js
@@ -1,9 +1,15 @@
 module.exports = {
   extends: [
-    'eslint:recommended',
+    'plugin:react/recommended',
     'airbnb',
     'airbnb/hooks',
   ],
+  plugins: ['react'],
+  parserOptions: {
+    ecmaFeatures: {
+      jsx: true,
+    },
+  },
   rules: {
     'react/jsx-filename-extension': ['error', {
       extensions: ['.jsx', '.tsx'],

diff --git a/typescript.js b/typescript.js
@@ -7,7 +7,6 @@ module.exports = {
     '@typescript-eslint',
   ],
   extends: [
-    'eslint:recommended',
     'plugin:@typescript-eslint/eslint-recommended',
     'plugin:@typescript-eslint/recommended',
     'plugin:@typescript-eslint/recommended-requiring-type-checking',