Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UEFI reference to RISC-V CC #119

Open
steven-bellock opened this issue Jan 3, 2025 · 4 comments
Open

UEFI reference to RISC-V CC #119

steven-bellock opened this issue Jan 3, 2025 · 4 comments
Assignees

Comments

@steven-bellock
Copy link
Contributor

#118 inspired me to look at the published UEFI specification, which has https://uefi.org/specs/UEFI/2.11/38_Confidential_Computing.html#risc-v-ap-tee and references AP-TEE, the name of this task group, rather than CoVE. Should this be changed, in a backwards compatible way, to CoVE? Ie

#define EFI_CC_TYPE_RISCV_APTEE    3
#define EFI_CC_TYPE_RISCV_COVE (EFI_CC_TYPE_RISCV_APTEE)

@jyao1 might know.

@rsahita
Copy link
Collaborator

rsahita commented Jan 4, 2025

yeah @jyao1 can you please update? thanks

@jyao1
Copy link
Contributor

jyao1 commented Jan 4, 2025

I checked #29.

It seems we use #define EFI_CC_TYPE_RISCV_APTEE 3 in the ECR.
UEFI 1.11 is just released. Even we submit ECR now. The next release might be another year.

On the other hand, I don't think using TG name is a big issue. E.g, we always use TCG_EVENT_LOG, not TPM _EVENT_LOG. It just means the TCG defined Event Log. Here it can be interpreted as AP-TEE TG defined CC type.

Please let me know your thought.

@rsahita
Copy link
Collaborator

rsahita commented Jan 4, 2025

Seems ok to me to keep it (we can update the note in the COVE spec calling out the define name used).

@steven-bellock
Copy link
Contributor Author

Even in #29 (comment) you've already got EFI_CC_TYPE_RISCV_COVE so that seems like the right choice. Once CoVE is published AP-TEE will probably be forgotten. UEFI can keep EFI_CC_TYPE_RISCV_APTEE in UEFI 1.12 for backwards compatibility, but just have it deprecated in favor of the EFI_CC_TYPE_RISCV_COVE name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants