transport: msgprot: Move the doorbell interrupt flag in transport #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avpatel
reviewed
Mar 3, 2025
src/message-protocol.adoc
Outdated
|
|
||
| 0b0: Doorbell interrupt is not requested. | ||
| 0b1: Doorbell interrupt is requested. | ||
| Refer the supported RPMI transport chapter for integration details. |
There was a problem hiding this comment.
s/Refer the supported RPMI transport .../Refer the corresponding RPMI transport .../
s/... for integration details./... for more details/
avpatel
reviewed
Mar 3, 2025
src/transport.adoc
Outdated
| @@ -291,6 +247,69 @@ from the currently running OS/firmware, notifications or response messages may | |||
| be delivered that are not intended for the newly spawned OS/firmware, and such | |||
| messages may be ignored. | |||
|
|
|||
| ==== Doorbell Interrupt | |||
| An RPMI transport may also provide optional doorbell interrupts for application | |||
There was a problem hiding this comment.
Since this now under shared memory transport sub-section, I would suggest referring "RPMI transport" as "RPMI shared memory transport" in the "Doorbell Interrupt" sub-section.
avpatel
reviewed
Mar 3, 2025
| may also contains other set bits which must persist on every write to the | ||
| doorbell register. | ||
|
|
||
| ==== Integration with RPMI Message Protocol |
There was a problem hiding this comment.
This should be "===== Integration with RPMI Message Protocol" so that it is under RPMI shared memory transport.
There was a problem hiding this comment.
No, its already under RPMI shared memory transport chapter which is ===
To make the message protocol independent from transport, move the doorbell interrupt detials into a separate chapter in RPMI transport which explains how the RPMI transport integrates with RPMI message protocol Signed-off-by: Rahul Pathak <rpathak@ventanamicro.com>
pathakraul
force-pushed
the
rpathak_trans_msgprot
branch
from
9302fda to
6e1251a
Compare
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the message protocol independent from transport, move the doorbell interrupt detials into a separate chapter in RPMI transport which explains how the RPMI transport integrates with RPMI message protocol.
This addresses the pending comment from Ved here #90