Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename uses of {implicit,explicit}-frm into {Implicit, Explicit} FP rounding modes #326

Merged
merged 2 commits into from
May 7, 2024
Merged

Rename uses of {implicit,explicit}-frm into {Implicit, Explicit} FP rounding modes #326

merged 2 commits into from
May 7, 2024

Conversation

rofirrim
Copy link
Collaborator

@rofirrim rofirrim commented May 3, 2024

See #320

@rofirrim rofirrim requested review from eopXD, kito-cheng and 4vtomat May 3, 2024 05:59
4vtomat
4vtomat approved these changes May 4, 2024
View reviewed changes
Copy link
Collaborator

@4vtomat 4vtomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ Thanks Roger!

kito-cheng
kito-cheng approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@kito-cheng kito-cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments, I guess that cause by string substitution? :P

rofirrim and others added 2 commits May 7, 2024 12:24
@rofirrim
Rename uses of {implicit,explicit}-frm into {Implicit, Explicit} FP r…
a3bbed2 
…ounding mode
@rofirrim @kito-cheng
Fix capital letters
e193559 
Co-authored-by: Kito Cheng <kito.cheng@gmail.com>
Signed-off-by: Roger Ferrer Ibáñez <rofirrim@gmail.com>
@rofirrim rofirrim force-pushed the explicit-implicit-frm branch from 9624c06 to e193559 Compare May 7, 2024 12:25
@rofirrim rofirrim merged commit 4440a9f into riscv-non-isa:main May 7, 2024
2 checks passed
@rofirrim rofirrim deleted the explicit-implicit-frm branch May 7, 2024 12:26
@rofirrim rofirrim mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kito-cheng kito-cheng kito-cheng approved these changes

@4vtomat 4vtomat 4vtomat approved these changes

@eopXD eopXD Awaiting requested review from eopXD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rofirrim @kito-cheng @4vtomat