Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI and missing implementations in derived classes #340

Merged
merged 10 commits into from
Jun 11, 2024
Merged

Fix CI and missing implementations in derived classes #340

merged 10 commits into from
Jun 11, 2024

Conversation

jerryzj
Copy link
Collaborator

@jerryzj jerryzj commented Jun 7, 2024 •
edited
Loading

  • Fixed derived classes do not have their own member function implementation, causing a runtime error.
  • All the linting/typecheck/yapf tests should be pass now
  • The diff-autogen test is failed due to some target feature missing in the bfloat16 API test, @4vtomat please help to check this It seems that the test files are not updated.
diff ./rvv-intrinsic-generator/.tmp/bfloat16/policy_funcs/llvm-overloaded-tests/vluxseg8ei16.c  rvv-intrinsic-doc-dev/auto-generated/bfloat16/policy_funcs/llvm-overloaded-tests/vluxseg8ei16.c
2c2,3
< // RUN: %clang_cc1 -triple riscv64 -target-feature +v \
---
> // RUN: %clang_cc1 -triple riscv64 -target-feature +v -target-feature +zfh \
> // RUN:   -target-feature +experimental-zvfh \

Signed-off-by: Jerry Zhang Jian jerry.zhangjian@sifive.com

@jerryzj jerryzj force-pushed the dev/jerryzj/fix-typecheck branch from ceea288 to 8d1752b Compare June 11, 2024 09:16
@jerryzj jerryzj force-pushed the dev/jerryzj/fix-typecheck branch from 8d1752b to f1ffc0b Compare June 11, 2024 09:26
jerryzj added 10 commits June 11, 2024 17:33
@jerryzj
[NFC] fix type-check errors by adding assertion
332e7de 
Signed-off-by: Jerry Zhang Jian <jerry.zhangjian@sifive.com>
@jerryzj
DocGenerator: remove start_group call of base class
27d982b 
Signed-off-by: Jerry Zhang Jian <jerry.zhangjian@sifive.com>
@jerryzj
APITestGenerator: implement dummy start_group
fb3383d 
Signed-off-by: Jerry Zhang Jian <jerry.zhangjian@sifive.com>
@jerryzj
APITestGenerator: implement dummy inst_group_prologue
c678607 
Signed-off-by: Jerry Zhang Jian <jerry.zhangjian@sifive.com>
@jerryzj
APITestGenerator: implement dummy inst_group_epilogue
28b7a9d 
Signed-off-by: Jerry Zhang Jian <jerry.zhangjian@sifive.com>
@jerryzj
APITestGenerator: implement dummy write function
55f6f94 
Signed-off-by: Jerry Zhang Jian <jerry.zhangjian@sifive.com>
@jerryzj
CompatibleHeaderGenerator: implement dummy start_group
95c44c0 
Signed-off-by: Jerry Zhang Jian <jerry.zhangjian@sifive.com>
@jerryzj
CompatibleHeaderGenerator: implement dummy inst_group_prologue
69554fb 
Signed-off-by: Jerry Zhang Jian <jerry.zhangjian@sifive.com>
@jerryzj
CompatibleHeaderGenerator: implement dummy inst_group_epilogue
f582ba9 
Signed-off-by: Jerry Zhang Jian <jerry.zhangjian@sifive.com>
@jerryzj
Let gen_prologue() pass execution by default
92fb9f6 
Signed-off-by: Jerry Zhang Jian <jerry.zhangjian@sifive.com>
@jerryzj jerryzj force-pushed the dev/jerryzj/fix-typecheck branch from eb87823 to 92fb9f6 Compare June 11, 2024 09:33
@kito-cheng kito-cheng merged commit 2d709dc into riscv-non-isa:main Jun 11, 2024
2 checks passed
@jerryzj jerryzj deleted the dev/jerryzj/fix-typecheck branch June 12, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kito-cheng kito-cheng kito-cheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerryzj @kito-cheng