Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector tester clean up #241

Merged

Conversation

kathlenemagnus
Copy link
Collaborator

Added a parameter to the Vector tester to be able to reduce code size. Also removed several redundant tests.

@jeffnye-gh
Copy link
Collaborator

I'm trying to determine if I have a problem in my environment.

I tried building this branch I get this:

/home/jeff/miniconda3/envs/sparta/include/sparta/utils/SpartaSharedPointer.hpp:376:31: error: pointer may be used after 'void operator delete(void*, std::size_t)' [-Werror=use-after-free]
376 | --ref_count_->count;
| ~~~~~~~~~~~~^~~~~
And this
/home/jeff/miniconda3/envs/sparta/include/sparta/utils/SpartaSharedPointer.hpp:365:21: note: call to 'void operator delete(void*, std::size_t)' here
365 | delete ref_count;
| ^~~~~~~~~~~~~~~~

I'm using this version of sparta
commit f1d0a5cdeb5ff718360a162d9ab7b13f19e70c3e (HEAD -> map_v2, tag: map_v2.0.19, origin/map_v2)
Merge: fdcc9275 05ba8532
Author: Knute Lingaard klingaard@gmail.com
Date: Thu Nov 14 13:34:19 2024 -0600

Merge remote-tracking branch 'origin/master' into map_v2

@kathlenemagnus
Copy link
Collaborator Author

@jeffnye-gh I've been using the master branch of Sparta (sparcians/map@e736f0d). I didn't realize there was a map_v2 branch. I'm not sure which I should be using. Does that stack trace show where the error originates in Olympia?

@kathlenemagnus kathlenemagnus merged commit 175595f into riscv-software-src:master Dec 18, 2024
5 checks passed
@klingaard
Copy link
Collaborator

That is weird. Which compiler/version are you using?

@jeffnye-gh
Copy link
Collaborator

deleted my other comment,

to your question: for me it's gcc 11, ubuntu 22.04. i've got a user on a mac with an error that looks similar on the surface.

i will see if i can get more detail,

@klingaard
Copy link
Collaborator

I'm using gcc 12 on ubuntu and didn't come across that. I then swapped to gcc 11 and tried that -- no problems. The version of sparta I have installed is map_v2.0.19

govardhnn pushed a commit to govardhnn/riscv-perf-model that referenced this pull request Jan 17, 2025
Added a parameter to the Vector tester to be able to reduce code size.
Also removed several redundant tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants