Branch Prediction Unit #243
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klingaard
reviewed
Mar 11, 2025
core/fetch/BPU.hpp
Outdated
Comment on lines
112
to
124
| uint32_t ghr_size_; | ||
| uint32_t ghr_hash_bits_; | ||
| uint32_t pht_size_; | ||
| uint32_t ctr_bits_; | ||
| uint32_t btb_size_; | ||
| uint32_t ras_size_; | ||
| bool ras_enable_overwrite_; | ||
| uint32_t tage_bim_table_size_; | ||
| uint32_t tage_bim_ctr_bits_; | ||
| uint32_t tage_tagged_table_num_; | ||
| uint32_t logical_table_num_; | ||
| uint32_t loop_pred_table_size_; | ||
| uint32_t loop_pred_table_way_; |
There was a problem hiding this comment.
Please provide default initializations OR make these const
core/fetch/TAGE_SC_L.hpp
Outdated
Comment on lines
69
to
79
| uint32_t tage_bim_table_size_; | ||
| uint8_t tage_bim_ctr_bits_; | ||
| uint16_t tage_max_index_bits_; | ||
| uint8_t tage_tagged_ctr_bits_; | ||
| uint8_t tage_tagged_useful_bits_; | ||
| uint32_t tage_global_hist_buff_len_; | ||
| uint32_t tage_min_hist_len_; | ||
| uint8_t tage_hist_alpha_; | ||
| uint32_t tage_reset_useful_interval_; | ||
| uint8_t tage_num_component_; | ||
| TageBIM tage_bim_; |
There was a problem hiding this comment.
Default initialize or make them const
core/fetch/TAGE_SC_L.hpp
Outdated
Comment on lines
51
to
53
| uint32_t tage_bim_table_size_; | ||
| uint8_t tage_base_ctr_bits_; | ||
| uint8_t tage_base_max_ctr_; |
There was a problem hiding this comment.
Default initialize or make them const
Comment on lines
+84
to
+94
| class StatisticalCorrector | ||
| { | ||
| public: | ||
| private: | ||
| }; | ||
|
|
||
| class LoopPredictor | ||
| { | ||
| public: | ||
| private: | ||
| }; |
There was a problem hiding this comment.
Yes, I intend to work on these once the rest of the bpu pipeline is working. I have commented them out for now.
…meters by const reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the draft PR for the implementation of branch prediction unit.