Added Vector 1.0 Uop Generation Support #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongchan
reviewed
Mar 10, 2025
| # TODO: Vector Loads and Stores: Unit-stride Fault-Only-First Loads | ||
| # TODO: Vector Loads and Stores: Vector Load/Store Segment Instructions | ||
| # TODO: Vector Loads and Stores: Vector Load/Store Whole Register Instructions | ||
| "vsetvli" : {"pipe" : "vset", "latency" : 1}, |
There was a problem hiding this comment.
Not sure how many more vector instructions would need to be added for this script, but for code readability would it be better to just make this it's own separate json file?
There was a problem hiding this comment.
I could create some header files that break things up a bit. I'll keep that in mind when we work on the vector load store instructions.
klingaard
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Olympia now supports uop generation for all vector instructions EXCEPT for some permutes (e.g. gathers, compresses, some complex slides). The uop generation for permutes is very dependent on how their execution unit is designed, so I've left them unimplemented for now. All types of uop generation have a test.