-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify mtval2/stval2/vstval2 handling #518
clarify mtval2/stval2/vstval2 handling #518
Conversation
Just to clarify that I understand the intent here: You are requiring it to be written to zero for non-CHERI traps? Is that actually needed, or can we just keep a stale value here for a non-CHERI fault? |
H has:
The point is that, by writing 0 now, you can detect non-zero values should it ever start to be used for another existing trap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two instances where vstval
should be vstval2
. Otherwise LGTM.
fix CSR names Signed-off-by: Tariq Kurd <tariqandlaura@gmail.com>
better description of the table Signed-off-by: Tariq Kurd <tariqandlaura@gmail.com>
whitespace Signed-off-by: Tariq Kurd <tariqandlaura@gmail.com>
they need to be updated on all exceptions, not just CHERI ones --------- Signed-off-by: Tariq Kurd <tariqandlaura@gmail.com>
they need to be updated on all exceptions, not just CHERI ones