Replace bounds decoding ascii art with bytefield diagram #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where's the extra 1'b0 in the diagram? |
that's what I was wondering - becaue the text in the box isn't wide enough without it |
|
I put the 1'b0 back. Now it looks like this |
tariqkurd-repo
approved these changes
Feb 6, 2025
arichardson
approved these changes
Feb 6, 2025
tariqkurd-repo
pushed a commit
to tariqkurd-repo/riscv-cheri
that referenced
this pull request
Feb 10, 2025
Replace the ascii art with the bounds decoding diagram to make it clear
how they are computed and what the resulting width of top and base.
This PR replaces this:
```
top: t = { {1'b0, a[MXLEN - 1:E + MW]} + ct, T[MW - 1:0], {E{1'b0}} }
base: b = { a[MXLEN - 1:E + MW] + cb, B[MW - 1:0], {E{1'b0}} }
```
With the bytefield figures in the attached image.
<img width="694" alt="Screenshot 2025-02-06 at 19 21 42" src="https://github.com/user-attachments/assets/521e4239-f23d-4bd2-b9a0-e242cf35cc41" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the ascii art with the bounds decoding diagram to make it clear how they are computed and what the resulting width of top and base.
This PR replaces this:
With the bytefield figures in the attached image.
