You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The new cmake build system #551#647 generates an executable named riscv_sim_rv32d. Could you make it generate the old name so it is easier for users to upgrade?
It could be a cmake option that installs a symlink with the old name so that people already updated don't get broken again.
Hmm most of those use c_emulator/riscv_sim_RVxx though, which wouldn't work anyway since the executables are generated in a build directory now.
The other wrinkle is that the name is going to (hopefully) change again when we build a single emulator that can do all xlen & flen combinations.
I kind of think enabling a CMake option is just as much work as editing the name... I guess we could put a symlink in the repo from c_emulator/riscv_sim_RV32 to ../build/c_emulator/riscv_sim_rv32d? Might be confusing that it starts off broken though...
I don't mind the change in the location of the built executable from c_emulator to the build folder with cmake. The location of the executable can be updated in the build script when switching to cmake.
I wouldn't hardcode the symlink to build. Users can specify any build folder name for cmake. It could be fine if the build guide explains to use exactly "build" as the folder name.
The new cmake build system #551 #647 generates an executable named riscv_sim_rv32d. Could you make it generate the old name so it is easier for users to upgrade?
It could be a cmake option that installs a symlink with the old name so that people already updated don't get broken again.
There are many projects and tutorials using the old name already.
The text was updated successfully, but these errors were encountered: