Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flen=32 compilation #441

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Fix flen=32 compilation #441

merged 1 commit into from
Apr 3, 2024

Conversation

Timmmm
Copy link
Collaborator

@Timmmm Timmmm commented Mar 19, 2024

This has been broken for at least 2 years. This fixes the compilation.

Fixes #351

@Timmmm
Fix flen=32 compilation
c898613 
This has been broken for at least 2 years. This fixes the compilation.

Fixes riscv#351
@github-actions GitHub Actions
Copy link

Test Results

712 tests  ±0   712 ✅ ±0   0s ⏱️ ±0s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit c898613. ± Comparison against base commit c287c34.

@billmcspadden-riscv billmcspadden-riscv added the tgmm-agenda Tagged for the next Golden Model meeting agenda. label Apr 1, 2024
billmcspadden-riscv
billmcspadden-riscv approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@billmcspadden-riscv billmcspadden-riscv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@billmcspadden-riscv billmcspadden-riscv merged commit a2ffa85 into riscv:master Apr 3, 2024
2 checks passed
@Timmmm Timmmm deleted the user/timh/flen32 branch April 4, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arichardson arichardson arichardson approved these changes

@billmcspadden-riscv billmcspadden-riscv billmcspadden-riscv approved these changes

Assignees
No one assigned
Labels
tgmm-agenda Tagged for the next Golden Model meeting agenda.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flen 32 (F extension only) does not compile
3 participants
@Timmmm @arichardson @billmcspadden-riscv