Refactor vext_mem remove redundant type annotations and simplify
#774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fy implementation These changes align with the general LOAD and STORE implementation pattern used elsewhere in the codebase.
pmundkur
requested changes
Mar 7, 2025
| @@ -263,13 +263,12 @@ function process_vsseg (nf, vm, vs3, load_width_bytes, rs1, EMUL_pow, num_elem) | |||
| else match translateAddr(vaddr, Write(Data)) { | |||
| TR_Failure(e, _) => { handle_mem_exception(vaddr, e); return RETIRE_FAIL }, | |||
| TR_Address(paddr, _) => { | |||
| let eares : MemoryOpResult(unit) = mem_write_ea(paddr, load_width_bytes, false, false, false); | |||
| let eares = mem_write_ea(paddr, load_width_bytes, false, false, false); | |||
There was a problem hiding this comment.
Can the mem_write_ea be folded into the match in the next line, like you did for the mem_write_value below? Similarly for the other cases of mem_write_ea later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes align with the general LOAD and STORE implementation pattern used elsewhere in the codebase.