fix use of uninitialized variable and removed wrong and unused constants #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BFP_EXT__ SNAN/QNAN/PINF/NINF/NEGZERO where intitialized from a double, but they all have a union type of which the first element is an int64_t. gcc warns about this, e.g. "overflow [...] changes value from '+SNaN' to '0'"
luhenry
requested changes
Sep 20, 2024
luhenry
approved these changes
Sep 23, 2024
keeranroth
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think there is a good/clean way to define the SNAN/QNAN/PINF/NINF/NEGZERO constants of type
sui64_fp64, because the code wants to initialize them using floats, but the tests definesui64_fp64withint64_t.That isn't portable, possible for unions.
Since the current value is wrong, and they aren't used, the easiest fix seems to be to remove them.