Restrict characters in URLs of packages and platforms #6962 #7730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+93
to
106
| if let Some((index, ch)) = url | ||
| .chars() | ||
| .any(|ch| MISLEADING_CHARACTERS_IN_URL.contains(&ch)) | ||
| .enumerate() | ||
| .find(|(_, ch)| (!ch.is_alphanumeric() && !ALLOWED_URL_CHARACTERS.contains(ch)) || MISLEADING_CHARACTERS_IN_URL.contains(ch)) | ||
| { | ||
| return Err(UrlProblem::MisleadingCharacter); | ||
| // Check if there is an intentionally misleading url character | ||
| // Otherwise check if there is a possibly insecure character in the url | ||
| if MISLEADING_CHARACTERS_IN_URL.contains(&ch) { | ||
| return Err(UrlProblem::MisleadingCharacter); | ||
| } else { | ||
| return Err(UrlProblem::InsecureCharacter((ch.to_string(), index))); | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
I think this'd be a bit easier to read/understand if rather than making this a single if, you split it out into two: one that's exactly like what was there before, and a second one after that to check this new condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parser functionality to throw an error if disallowed URL characters appear to mitigate security issues through platforms and package url's