Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support scheduled lambdas #106

Merged
merged 5 commits into from
Apr 5, 2024
Merged

support scheduled lambdas #106

merged 5 commits into from
Apr 5, 2024

Conversation

kristielim
Copy link
Contributor

No description provided.

@auto-assign auto-assign bot requested a review from pmenglund April 4, 2024 01:52
@kristielim kristielim force-pushed the kristie_scheduled_lambdas branch from 8b1c81b to bc23898 Compare April 4, 2024 16:21
@ibrahimjelliti
Copy link

@kristielim scheduled lambda can be async, current I see only Python SDK can create async Scheduled lambda
would be great if we can add async_req to resourceScheduledLambda schema

Copy link
Member

@pmenglund pmenglund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a few nits

@pmenglund
Copy link
Member

scheduled lambda can be async, current I see only Python SDK can create async Scheduled lambda would be great if we can add async_req to resourceScheduledLambda schema

@ibrahimjelliti the async_req is for the CreateScheduledLambda() call, not the invocation of the scheduled query lambda itself, which always is async (we have no synchronous invocation of a scheduled query lambda)

@kristielim kristielim enabled auto-merge (squash) April 5, 2024 21:35
@kristielim kristielim merged commit d2ed882 into master Apr 5, 2024
3 checks passed
@kristielim kristielim deleted the kristie_scheduled_lambdas branch April 5, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants