Merge 'compaction: upgrade: handle keyspaces that use tablets' from Lakshmi Narayanan Sreethar

Tables in keyspaces governed by replication strategy that uses tablets, have separate effective_replication_maps. Update the upgrade compaction task to handle this when getting owned key ranges for a keyspace.

Fixes scylladb#16848

Closes scylladb#17335

* github.com:scylladb/scylladb:
  compaction: upgrade: handle keyspaces that use tablets
  replica/database: add an optional variant to get_keyspace_local_ranges

Author: avikivity

compaction/task_manager_module.cc

@@ -531,7 +531,8 @@ future<> shard_upgrade_sstables_compaction_task_impl::run() {
 
 future<> table_upgrade_sstables_compaction_task_impl::run() {
     co_await wait_for_your_turn(_cv, _current_task, _status.id);
-    auto owned_ranges_ptr = compaction::make_owned_ranges_ptr(_db.get_keyspace_local_ranges(_status.keyspace));
+    auto owned_ranges = _db.maybe_get_keyspace_local_ranges(_status.keyspace);
+    auto owned_ranges_ptr = owned_ranges ? compaction::make_owned_ranges_ptr(std::move(owned_ranges.value())) : nullptr;
     tasks::task_info info{_status.id, _status.shard};
     co_await run_on_table("upgrade_sstables", _db, _status.keyspace, _ti, [&] (replica::table& t) -> future<> {
         return t.parallel_foreach_table_state([&] (compaction::table_state& ts) -> future<> {

replica/database.cc

@@ -2591,6 +2591,16 @@ dht::token_range_vector database::get_keyspace_local_ranges(sstring ks) {
     return find_keyspace(ks).get_vnode_effective_replication_map()->get_ranges(my_address);
 }
 
+std::optional<dht::token_range_vector> database::maybe_get_keyspace_local_ranges(sstring ks) {
+    const auto& keyspace = find_keyspace(ks);
+    if (keyspace.get_replication_strategy().is_per_table()) {
+        // return nullopt if each tables have their own effective_replication_map
+        return std::nullopt;
+    }
+    auto my_address = get_token_metadata().get_topology().my_address();
+    return keyspace.get_vnode_effective_replication_map()->get_ranges(my_address);
+}
+
 /*!
  * \brief a helper function that gets a table name and returns a prefix
  * of the directory name of the table.

replica/database.hh

@@ -1800,6 +1800,7 @@ public:
     // Returns the list of ranges held by this endpoint
     // The returned list is sorted, and its elements are non overlapping and non wrap-around.
     dht::token_range_vector get_keyspace_local_ranges(sstring ks);
+    std::optional<dht::token_range_vector> maybe_get_keyspace_local_ranges(sstring ks);
 
     void set_format(sstables::sstable_version_types format) noexcept;
     void set_format_by_config();